Nonblocking commits (#3340)

* Debug tracing for nonblocking commit

* Disable logging messages- looking for an assertion failure about committing a non-temporary page

* debug logging

* Check for issue with Arroyo state collapsing

* more debugging

* more debug

* Coordination bt gc & commit tasks

* disable nonblocking commits

* Coordination between page garbage collection and commits

* Stricter criterion for when pages can be garbage collected

* Use unique db names for testing

* typo

* Kludge for issue with accessing temporary pages after transaction released, when reporting AbortException

* comment

* Fix for AbortException issue

* oops

* debugging for no_self_edges failures

* IFL heisenbugs

* Use unique db names for RAIVM benchmarks

* gen_safe_dbname typo

* gen_safe_dbname() fix

* comment

* debugging

* PR feedback

* handling of CREATE_OVERWRITE

* ..

* mutex to ensure CommitManager.prev_tip_pageid and KV store are updated together

* [ClientSDKs] Generated SDK changes for `wait_durable`

* Do not use objectid to detect objects we have encountered before, because objectids are not unique for immutable objects.

* Fix connection versioning test failures

* Fix failing unit test error_handling

* tweak

* run_actions() use wait_durable=true

* generate-client-sdks.sh

* whups

* fix

* Disable DevilSpawn.jl

* disable assert

* cleanup

* cleanup

* Commit generated change to incubator/ClientSDKs/javascript-client-sdk/client/test/Transaction.spec.js

* Temporarily disable blocking commits to see effect on benchmarks

* whups

* Consistently use default of wait_durable=true

* Use IdDict{Any,Nothing} rather than Set{Any}, to avoid issue with Vector(undef,N)

* Reduce allocations in collect_relations()

* tweaks

* mmmhmm

* Change wait_durable to nowait_durable, because protocol boolean flags must have default false

* tweak

* remove testing code

* .

* Update src/API/Server/Server.jl

Co-authored-by: Nikolas Göbel <nikolas.goebel@relational.ai>

* PR feedback

* fix wrong default

Co-authored-by: Todd Veldhuizen <>
Co-authored-by: Mohammad Dashti <mdashti@gmail.com>
Co-authored-by: Rob Bearman <robbear@hyperfine.com>
Co-authored-by: Nikolas Göbel <nikolas.goebel@relational.ai>

Author: 4 people

client/docs/Transaction.md

@@ -9,6 +9,7 @@ Name | Type | Description | Notes
 **dbname** | **String** |  | [default to '']
 **debugLevel** | **Number** |  | [optional] 
 **mode** | **String** |  | [default to 'OPEN']
+**nowaitDurable** | **Boolean** |  | [default to false]
 **readonly** | **Boolean** |  | [default to false]
 **sourceDbname** | **String** |  | [optional] 
 **version** | **Number** |  | [optional] 

client/src/model/Transaction.js

@@ -26,23 +26,25 @@ class Transaction {
      * @param abort {Boolean} 
      * @param dbname {String} 
      * @param mode {module:model/Transaction.ModeEnum} 
+     * @param nowaitDurable {Boolean} 
      * @param readonly {Boolean} 
      * @param type {module:model/Transaction.TypeEnum} 
      */
-    constructor(abort, dbname, mode, readonly, type) { 
+    constructor(abort, dbname, mode, nowaitDurable, readonly, type) { 
 
-        Transaction.initialize(this, abort, dbname, mode, readonly, type);
+        Transaction.initialize(this, abort, dbname, mode, nowaitDurable, readonly, type);
     }
 
     /**
      * Initializes the fields of this object.
      * This method is used by the constructors of any subclasses, in order to implement multiple inheritance (mix-ins).
      * Only for internal use.
      */
-    static initialize(obj, abort, dbname, mode, readonly, type) { 
+    static initialize(obj, abort, dbname, mode, nowaitDurable, readonly, type) { 
         obj['abort'] = abort || false;
         obj['dbname'] = dbname || '';
         obj['mode'] = mode || 'OPEN';
+        obj['nowait_durable'] = nowaitDurable || false;
         obj['readonly'] = readonly || false;
         obj['type'] = type || 'Transaction';
     }
@@ -73,6 +75,9 @@ class Transaction {
             if (data.hasOwnProperty('mode')) {
                 obj['mode'] = ApiClient.convertToType(data['mode'], 'String');
             }
+            if (data.hasOwnProperty('nowait_durable')) {
+                obj['nowait_durable'] = ApiClient.convertToType(data['nowait_durable'], 'Boolean');
+            }
             if (data.hasOwnProperty('readonly')) {
                 obj['readonly'] = ApiClient.convertToType(data['readonly'], 'Boolean');
             }
@@ -120,6 +125,12 @@ Transaction.prototype['debug_level'] = undefined;
  */
 Transaction.prototype['mode'] = 'OPEN';
 
+/**
+ * @member {Boolean} nowait_durable
+ * @default false
+ */
+Transaction.prototype['nowait_durable'] = false;
+
 /**
  * @member {Boolean} readonly
  * @default false

client/test/model/Transaction.spec.js

@@ -84,6 +84,12 @@
       //expect(instance).to.be();
     });
 
+    it('should have the property nowaitDurable (base name: "nowait_durable")', function() {
+      // uncomment below and update the code to test the property nowaitDurable
+      //var instane = new RaiDbSdk.Transaction();
+      //expect(instance).to.be();
+    });
+
     it('should have the property readonly (base name: "readonly")', function() {
       // uncomment below and update the code to test the property readonly
       //var instane = new RaiDbSdk.Transaction();