refactor: improve public interface + don't expose resolver#37
refactor: improve public interface + don't expose resolver#37
Conversation
| contexts instanceof Map ? contexts : contextObjToMap(contexts); | ||
| } | ||
|
|
||
| get telemetry(): Telemetry | undefined { |
There was a problem hiding this comment.
Does this actually need to be exposed?
There was a problem hiding this comment.
the only reason i could see exposing this is when debugging telemetry or wanting to force a flush. I think that probably means it ought not be exposed.
| }); | ||
| } | ||
|
|
||
| getLogLevel(loggerName: string): LogLevel { |
There was a problem hiding this comment.
Same here. expose this?
There was a problem hiding this comment.
seems wrong that it isn't accepting an optional context like shouldLog. It seems reasonable to be able to ask "what is log level?" as a variation of shouldLog, but I'm ok removing until someone asks.
| withContext(contexts: Contexts | ContextObj): ReforgeInterface { | ||
| const mergedContexts = mergeContexts(this.context, contexts); | ||
| return new ReforgeClient(this.parent, mergedContexts); | ||
| } | ||
|
|
||
| inContext<T>( |
There was a problem hiding this comment.
Do we want to support both of these?
There was a problem hiding this comment.
I don't have a strong enough opinion here about what would be most useful across various node setups.
There was a problem hiding this comment.
OK - I'll think about it and will probably pull one out.
mjfaga
force-pushed
the
mfaga-update-sdk-api
branch
from
0ef2f5f to
6057612
Compare
2 participants
No description provided.