Change FORTRAN_STRLEN type in installed headers.#1181
Merged
langou merged 4 commits intoReference-LAPACK:masterfrom Jan 13, 2026
Merged
Change FORTRAN_STRLEN type in installed headers.#1181langou merged 4 commits intoReference-LAPACK:masterfrom
langou merged 4 commits intoReference-LAPACK:masterfrom
Conversation
…like the lapack.h header.
langou
approved these changes
Jan 13, 2026
amontoison
reviewed
Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some time ago I introduced the
FORTRAN_STRLENtype to make the type of the hidden strlen arguments configurable because the NAG Fortran compiler usesintinstead ofsize_t. The headers that are installed are still using thesize_tdefinition and the user would need to define FORTRAN_STRLEN each time they compiler and link against the LAPACK lib built with nagfor. To fix that the type is now changed in the installed header if it differs fromsize_t.Additionally I fixed the include of
cblas_mangling.h. It was included in cblas.h but only used bycblas_f77.h.The
lapack.handcblas_f77.hare now also installed when LAPACKE and CBLAS are not enabled. They don't need the LAPACKE or CBLAS libraries and could be used independently. If you are not happy with that change let me know and I'll revert it.