Fix xGESVDQ's jobu and jobv support in LAPACKE#1146
Open
yizeyi18 wants to merge 1 commit intoReference-LAPACK:masterfrom
Open
Fix xGESVDQ's jobu and jobv support in LAPACKE#1146yizeyi18 wants to merge 1 commit intoReference-LAPACK:masterfrom
xGESVDQ's jobu and jobv support in LAPACKE#1146yizeyi18 wants to merge 1 commit intoReference-LAPACK:masterfrom
Conversation
yizeyi18
changed the title
xGESVDQ's jobu and jobv support in LAPACKE
angsch
reviewed
Feb 22, 2026
Collaborator
angsch
left a comment
angsch
left a comment
There was a problem hiding this comment.
the missing job options are good catch
| lapack_int nrows_v = API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) ? n : | ||
| ( API_SUFFIX(LAPACKE_lsame)( jobv, 's' ) ? MIN(m,n) : 1); | ||
| ( (API_SUFFIX(LAPACKE_lsame)( jobu, 's' ) || | ||
| API_SUFFIX(LAPACKE_lsame)( jobu, 'u' ) ) ? MIN(m,n) : 1); |
Collaborator
There was a problem hiding this comment.
Shouldn't jobu = 'f' and jobu = 'r' be included here too?
| goto exit_level_0; | ||
| } | ||
| if( API_SUFFIX(LAPACKE_lsame)( jobu, 'a' ) || API_SUFFIX(LAPACKE_lsame)( jobu, 's' ) ) { | ||
| if( API_SUFFIX(LAPACKE_lsame)( jobu, 'a' ) || API_SUFFIX(LAPACKE_lsame)( jobu, 's' ) || |
Collaborator
There was a problem hiding this comment.
Since the jobu = 'a', 's', 'u', 'r', 'f' conditional is repeated several times, it may be worth to declare an ancillary variable to wrap the status. An analogous comment applies to jobv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LAPACKE provides interface to
xGESVDQ, although not included inDOCS/lapacke.pdf. In the implementation of the interface,jobuandjobvare treated as the same as inxGESVD, causing"U","R","F"variant ofjobuand"V","R"variant ofjobvnot handled.This PR appends support of these variant of
jobuandjobvin LAPACKE's interface toxGESVDQ.For not founding the way to edit
DOCS/lapacke.pdf, the documentation remains unchanged.Checklist