remove duplicate symbols for real gcc10 compatibility #825
Draft
DvirDukhan wants to merge 2 commits intomasterfrom
Draft
remove duplicate symbols for real gcc10 compatibility #825DvirDukhan wants to merge 2 commits intomasterfrom
DvirDukhan wants to merge 2 commits intomasterfrom
Conversation
rafie
previously approved these changes
Jul 26, 2021
chayim
previously approved these changes
Jul 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
+ Coverage 79.91% 79.96% +0.04%
==========================================
Files 53 53
Lines 8044 8019 -25
==========================================
- Hits 6428 6412 -16
+ Misses 1616 1607 -9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
-fcommonto gcc compile flag, to avoid errors on multiple definitions of the same variable.see https://gcc.gnu.org/gcc-10/porting_to.html
however, this is just a workaround and we should have a proper, in-depth solution