RHINENG-22821: temporarily increate ratelimit

[Dugowitch]

I hope this change will enable us to basically DOS attack an endpoint and evaluate the high-req-per-second hypothesis for RHINENG-22821.

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

Summary by Sourcery

Enhancements:

• Raise the RATELIMIT configuration from 100 to 1000 requests per second in the ClowdApp deployment manifest.

Summary by Sourcery

Enhancements:

• Raise the configured request rate limit from 100 to 1000 requests per second in the deployment parameters.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Increases the configured RATELIMIT parameter in the ClowdApp deployment manifest from 100 to 1000 requests per second to temporarily allow higher request throughput for testing.

Sequence diagram for request handling with updated RATELIMIT

sequenceDiagram
    actor Client
    participant Ingress
    participant ServicePod
    participant RateLimiter
    participant UpstreamHandler

    Client->>Ingress: HTTP request
    Ingress->>ServicePod: Forward request
    ServicePod->>RateLimiter: Check allowed(RATELIMIT=1000)
    alt under_limit
        RateLimiter-->>ServicePod: allowed
        ServicePod->>UpstreamHandler: Process request
        UpstreamHandler-->>ServicePod: Response
        ServicePod-->>Ingress: HTTP 2xx/4xx/5xx
        Ingress-->>Client: Response
    else over_limit
        RateLimiter-->>ServicePod: rejected
        ServicePod-->>Ingress: HTTP 429
        Ingress-->>Client: HTTP 429 Too Many Requests
    end

Loading

File-Level Changes

Change	Details	Files
Increase the leaky-bucket rate limit to allow up to 1000 requests per second.	Update the RATELIMIT parameter value from 100 to 1000 in the deployment configuration parameters section Preserve all other deployment parameters and comments unchanged to maintain existing behavior aside from rate limiting	deploy/clowdapp.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.36%. Comparing base (ff33bf9) to head (aebd26f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
- Coverage   59.39%   59.36%   -0.03%     
==========================================
  Files         134      134              
  Lines        8678     8678              
==========================================
- Hits         5154     5152       -2     
- Misses       2977     2979       +2     
  Partials      547      547              

Flag	Coverage Δ
unittests	59.36% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sourcery-ai]

Hey - I've left some high level feedback:

• Given this is intended as a temporary change to support load/DOS-style testing, consider scoping the higher RATELIMIT to a non-production environment or a dedicated testing configuration rather than changing the shared default parameter.
• It would be helpful to encode the temporary nature of this change directly in the config (e.g., via a comment with the RHINENG-22821 reference and revert criteria) so it’s clear when and why this should be rolled back.
• Raising the RATELIMIT by 10x may impact upstream/downstream components’ stability and monitoring signals; consider whether additional protective limits (e.g., at the ingress or per-IP level) are needed to avoid unintended collateral effects during your experiment.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Given this is intended as a temporary change to support load/DOS-style testing, consider scoping the higher RATELIMIT to a non-production environment or a dedicated testing configuration rather than changing the shared default parameter.
- It would be helpful to encode the temporary nature of this change directly in the config (e.g., via a comment with the RHINENG-22821 reference and revert criteria) so it’s clear when and why this should be rolled back.
- Raising the RATELIMIT by 10x may impact upstream/downstream components’ stability and monitoring signals; consider whether additional protective limits (e.g., at the ingress or per-IP level) are needed to avoid unintended collateral effects during your experiment.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}