Use RMG-py binary in travis build #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently uses v1.0.2 avoids having to compile RMG-Py when you only want to check the database.
so that we can run tests without the need for RMG-Py source code info
Member
|
Do we propose that we keep the databaseTest.py on both repos or should we be removing the one from RMG-Py? |
Contributor
Author
|
for now, I would keep it: I believe test-database is also good to test some of the RMG-Py functionalities, which might not necessarily be covered by other unit tests. |
nickvandewiele
added a commit
that referenced
this pull request
Feb 3, 2016
Use RMG-Py binary in travis build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of compiling RMG-Py to the latest version, we fetch the anaconda binary of RMG-Py.
testing/databaseTest.py was copied from RMG-Py, and a
test-databasetarget was added.Current build times on travis take 120s.
Currently uses v1.0.2 of RMG-Py.