Adding more nodes in some kinetics families tree #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfarinajr
approved these changes
Jul 7, 2021
Contributor
davidfarinajr
left a comment
davidfarinajr
left a comment
There was a problem hiding this comment.
Looks good! Thanks Ting-Chen! I didn't look at this super carefully, but the database tests are good at picking up errors in the trees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Adding more nodes in some kinetics families tree for training data
Description:
A separated PR from Add training reactions and enlarge the nodes in the tree for some surface reaction families #479
Separating previous one into three PRs: "adding libraries", "adding tree nodes", and "adding training data"