-
Notifications
You must be signed in to change notification settings - Fork 154
Halogens kinetics #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Halogens kinetics #472
Conversation
f37e252 to
befebc7
Compare
| 4 C u0 p0 c0 {3,S} {5,D} {10,S} | ||
| 5 C u0 p0 c0 {4,D} {6,S} {12,S} | ||
| 6 *1 C u0 p0 c0 {1,D} {5,S} {7,S} | ||
| 1 *2 C u0 p0 c0 {2,B} {6,B} {8,S} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change from kekulized to aromatic intentional and beneficial?
befebc7 to
5c616f0
Compare
5c616f0 to
d9a3223
Compare
|
Now simultaneous with PR ReactionMechanismGenerator/RMG-Py#2135 because we need to swap labels for new own reverse families |
Lol, we just changed this from 6 to 7 when CO was added to primaryThermoLibrary 😂. I add a bunch of training reactions in this PR, so I must have altered the kinetics so we get 6 now instead of 7. |
looks like the kinetics are being compared in opposite directions 🤔 |
|
Change in observables: |
New `intra_Y_migration` (Y=F,Cl,Br) should be made when we have more kinetic data for these
Note: this family should be rebuilt using automated tree gen
…smGenerator/RMG-database into halogens_kinetics
a7c68bc to
bc3a0c3
Compare
This PR adds halogens to the kinetics database
Note: the database tests will not pass until ReactionMechanismGenerator/RMG-Py#1997 is merged since the PR depends on the
R!H!Val7atomtypeFAMILIES
New Families -
F_Abstraction,Cl_Abstraction,Br_Abstraction,Disproportionation-Y,XY_Addition_MulitpleBond,1,2_XY_interchangeThe families are put in a new
halogensset in recommended.py acb9b8fExisting Families -
The strategy for adding halogens to existing families was primarily to add the
Val7atomtype to H atom nodesH_Abstraction - new groups are machine written, *3 halogen atom abstractors, added training reactions
Disproportionation -new groups are machine written, *1 halogen atom abstractors, added training reactions
R_Addition_MulitpleBond - new groups are machine written, *3 halogen atoms can add, added training reactions
1,2_Insertion_carbene - added halogens and training reactions
1+2_Cycloaddition - H -> [H,Val7] for unlabeled atoms
1,2-Birad_to_alkene - H -> [H,Val7] for unlabeled atoms
1,2_Insertion_CO - *3 H -> [H,Val7]
1,3_Insertion_CO2 - *3 halogens
1,3_Insertion_ROR - - *3 H -> [H,Val7]
Birad_R_Recombination - machine written, *1 [H,Val7]
Intra_H_migration - *3 H -> [H,Val7] (halogens can migrate).
Plan to make new families (intra_X_migration) when we have more kinetic dataSinglet_Carbene_Intra_Dispropotionation -*3 H -> *3 [H,Val7]
CO_Dispropotionation - machine written H -> [H,Val7]
R_Recombination - new halogen groups added, new training reactions,
this family should be reconstructed with automated tree genIntra_Disproportionation - *4 H -> [H,Val7]
Intra_ene_reaction - *6 H -> *6 [H,Val7]
Concerted Intra Diels alder monocyclic 1,2 shiftH - *7 H -> [H,Val7]
2+2_cycloaddition_CCO - H -> [H,Val7]
2+2_cycloaddition_Cd - H -> [H,Val7]
2+2_cycloaddition_CO - H -> [H,Val7]
Intra_RH_Add_Endocyclic - H -> [H,Val7]
Intra_RH_Add_Exocyclic - H -> [H,Val7]
ketoenol groups - H -> [H,Val7]
R_Addition_COm - H -> [H,Val7]
LIBRARIES
HFC mech (NIST)
CH2F2 (NIST)
YF
2-BTP/CF3Br (NIST)
DTU mech CH3Cl