import statements in unit tests outdated. #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I thought this would be a quick fix. I have tracked down many of the moved classes, but some things seem to have changed a lot, and I feel that some (many? most?) of these tests have actually been replaced with tests in the higher level folder. Might that be true, @jwallen? |
This was used in some of the old unit tests.
Some of these seem very broken. I am wondering how many of them have been sufficiently replaced with the tests in the higher level folder that these can be discarded?
-testEquivalent -testIsSpecificCaseOf -testOutput -testSetActions -TestGetAtomType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
several unittest modules (e.g. unittest/rmg/thermotest.py) have outdated import statements:
-rmg.data --> rmgpy.data
-rmg.structure --> ? (don't know where that went)
...
my guess is that when packages/modules were renamed, the unittest folder was not updated.