Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ jobs:
os: [macos-13, macos-latest, ubuntu-latest]
include-rms: ["", "with RMS"]
exclude:
- os: macos-latest # needs Cantera 3 b/c x86 emulation breaks with Julia
include-rms: 'with RMS'
- os: macos-13 # GitHub's runners just aren't up to the task of installing Julia
include-rms: 'with RMS'
runs-on: ${{ matrix.os }}
Expand All @@ -73,10 +71,6 @@ jobs:
- name: Checkout RMG-Py
uses: actions/checkout@v4

- name: Compel Arm-based Mac to use x86
if: matrix.os == 'macos-latest'
run: echo "CONDA_SUBDIR=osx-64" >> $GITHUB_ENV

- name: Setup Miniforge Python ${{ matrix.python-version }}
uses: conda-incubator/setup-miniconda@v3
with:
Expand All @@ -87,7 +81,6 @@ jobs:
activate-environment: rmg_env
auto-update-conda: true
show-channel-urls: true
channels: conda-forge,cantera,rmg
conda-remove-defaults: "true"

# list the environment for debugging purposes
Expand Down Expand Up @@ -164,7 +157,6 @@ jobs:
activate-environment: rmg_env
auto-update-conda: true
show-channel-urls: true
channels: conda-forge,cantera,rmg
conda-remove-defaults: "true"

# list the environment for debugging purposes
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
activate-environment: rmg_env
use-mamba: true
show-channel-urls: true
channels: conda-forge,cantera,rmg

- name: Install sphinx
run: mamba install -y sphinx
Expand Down
5 changes: 2 additions & 3 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
name: rmg_env
channels:
- conda-forge
- cantera
- rmg
dependencies:
# System-level dependencies - we could install these at the OS level
Expand All @@ -46,7 +45,7 @@ dependencies:

# external software tools for chemistry
- conda-forge::coolprop
- cantera::cantera =2.6
- conda-forge::cantera =2.6
- conda-forge::mopac
# see https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2639#issuecomment-2050292972
- conda-forge::cclib >=1.6.3,<1.9
Expand All @@ -59,7 +58,7 @@ dependencies:
- conda-forge::cython >=0.25.2
- conda-forge::scikit-learn
- conda-forge::scipy >=1.9
- conda-forge::numpy >=1.10.0
- conda-forge::numpy >=1.10.0,<2
- conda-forge::pydot
- conda-forge::jinja2
- conda-forge::jupyter
Expand Down
10 changes: 5 additions & 5 deletions test/rmgpy/solver/liquidTest.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,21 +167,21 @@ def test_compute_flux(self):

# Check that we're computing the species fluxes correctly
for i in range(t.shape[0]):
assert abs(reaction_rates[i, 0] - species_rates[i, 0]) < abs(
assert abs(reaction_rates[i, 0] - species_rates[i, 0]) <= abs(
1e-6 * reaction_rates[i, 0]
)
assert abs(reaction_rates[i, 0] - -species_rates[i, 1]) < abs(
assert abs(reaction_rates[i, 0] - -species_rates[i, 1]) <= abs(
1e-6 * reaction_rates[i, 0]
)
assert abs(reaction_rates[i, 0] - -species_rates[i, 2]) < abs(
assert abs(reaction_rates[i, 0] - -species_rates[i, 2]) <= abs(
1e-6 * reaction_rates[i, 0]
)
assert abs(reaction_rates[i, 0] - species_rates[i, 3]) < abs(
assert abs(reaction_rates[i, 0] - species_rates[i, 3]) <= abs(
1e-6 * reaction_rates[i, 0]
)

# Check that we've reached equilibrium
assert abs(reaction_rates[-1, 0] - 0.0) < 1e-2
assert abs(reaction_rates[-1, 0] - 0.0) <= 1e-2

def test_jacobian(self):
"""
Expand Down
Loading