RMG-Electrochem#2316

Closed

mjohnson541 wants to merge 110 commits intomainfrom

electrochem

Commits on Jul 27, 2023

Add reaction library to test example for liquidSurfaceReactor
mjohnson541
committed
added Faraday's Constant `F`

davidfarinajr
authored and
mjohnson541
committed
added Potential as `V` quantity

davidfarinajr
authored and
mjohnson541
committed
added `H+` and `e` atomtypes, increment/decrement charge attributes

davidfarinajr
authored and
mjohnson541
committed
added atomtype unit tests

davidfarinajr
authored and
mjohnson541
committed
added `gain_charge` and `lose_charge` actions

davidfarinajr
authored and
mjohnson541
committed
added `is_proton` and `is_electron` group methods

davidfarinajr
authored and
mjohnson541
committed
added group unit tests

davidfarinajr
authored and
mjohnson541
committed
added `is_electron` and `is_proton` methods to Atom and Mol

davidfarinajr
authored and
mjohnson541
committed
added GAIN and LOSE CHARGE actions to Atoms

davidfarinajr
authored and
mjohnson541
committed
added updated charge method and revised `update` Molecule method

davidfarinajr
authored and
mjohnson541
committed
do not raise charge exception by default when creating molecule from adj list

davidfarinajr
authored and
mjohnson541
committed
H -> H0 in find_h_bonds Molecule method

davidfarinajr
authored and
mjohnson541
committed
try to generate_resonance_structures, and return a deep copy of the molecule if it fails

davidfarinajr
authored and
mjohnson541
committed
added molecule.pxd declarations

davidfarinajr
authored and
mjohnson541
committed
added Species `is_electron` and `is_proton` methods

davidfarinajr
authored and
mjohnson541
committed
do not raise charge exception by default when creating species from adj list

davidfarinajr
authored and
mjohnson541
committed
added `get_net_charge` method for Species

davidfarinajr
authored and
mjohnson541
committed
do not forbid ions

davidfarinajr
authored and
mjohnson541
committed
added `SurfaceChargeTransfer` and `SurfaceChargeTransferBEP` kinetic models

davidfarinajr
authored and
mjohnson541
committed
added unit tests for SurfaceChargeTranser kinetic model

davidfarinajr
authored and
mjohnson541
committed
added Molecule unit tests

davidfarinajr
authored and
mjohnson541
committed
added `electrons` reaction attr and reaction methods for charge transfer reactions

davidfarinajr
authored and
mjohnson541
committed
added reaction tests for charge transfer reactions

davidfarinajr
authored and
mjohnson541
committed
adding charged species and electrons to family.py

davidfarinajr
authored and
mjohnson541
committed
added family test for `Surface_Proton_Electron_Reduction_Alpha` family

davidfarinajr
authored and
mjohnson541
committed
added support for loading `SurfaceChargeTransfer` kinetics from the database

davidfarinajr
authored and
mjohnson541
committed
update charge before updating lone pairs for solvation `transform_lone_pairs` method

davidfarinajr
authored and
mjohnson541
committed
making rules for SurfaceChargeTransfer training reactions

davidfarinajr
authored and
mjohnson541
committed
added SurfaceChargeTransfer kinetics import

davidfarinajr
authored and
mjohnson541
committed
added H+ and e to translator

davidfarinajr
authored and
mjohnson541
committed
update_atomtypes -> update in translator.py

davidfarinajr
authored and
mjohnson541
committed
added `SurfaceChargeTransfer` to yml

davidfarinajr
authored and
mjohnson541
committed
added `adsorption_groups` attr to thermoDB

davidfarinajr
authored and
mjohnson541
committed
added fluorine to thermo `correct_binding_energy` method

davidfarinajr
authored and
mjohnson541
committed
add LiH and LiF to atom energy corrections fitting species list
mjohnson541
committed
add Li atom spin
mjohnson541
committed
don't check Li partial charges in adjlists
mjohnson541
committed
add Li atomtype
mjohnson541
committed
add atom information for Li
mjohnson541
committed
handle Lithium electron calculations
mjohnson541
committed
handle SurfaceChargeTransfer in to_rms
mjohnson541
committed
add Li to R and R!H lists
mjohnson541
committed
filter out resonance structures that try to put - charges on Li
mjohnson541
committed
add Li McGowan volume
mjohnson541
committed
add is_lithium for GroupAtom
mjohnson541
committed
add additional Li BDEs
mjohnson541
committed
add Li to bond dictionaries in thermo
mjohnson541
committed
ensure atomtypes get updated on loading in thermo entries
mjohnson541
committed
add solute data to KineticsModel and Arrhenius
mjohnson541
committed
add ArrheniusChargeTransfer kinetics type
mjohnson541
committed
create ArrheniusChargeTransferBM type
mjohnson541
committed
add ChargeTransfer types to kinetics/__init__.py
mjohnson541
committed
avoid issue with auto decay reactions
mjohnson541
committed
handle ChargeTransfer kinetics with in reaction.py
mjohnson541
committed
add handling ArrheniusChargeTransfer and fix handling SurfaceChargeTransfer for rms output
mjohnson541
committed
Revert "Remove charge transfer types from average_kinetics (to be reverted)"

rwest
authored and
mjohnson541
committed
enable access to SoluteData object in kinetics database
mjohnson541
committed
update rule fitting
mjohnson541
committed
enable use of non-surface charge transfer families
mjohnson541
committed
add charge transfer types to database context
mjohnson541
committed
add Li0 and Li+ atomtypes
mjohnson541
committed
enable surface and bulk potentials to be specified separately
mjohnson541
committed
Allow approximating a solvent not in the database with another solvent
mjohnson541
committed
standardize ascend option in cross validate
mjohnson541
committed
Average kinetics when n=1 or E0<0
mjohnson541
committed
add comment to averaged kinetics
mjohnson541
committed
fix BM fitting
mjohnson541
committed
add functions for solvent correcting kinetics
mjohnson541
committed
add functionality for site specific solvent corrections
mjohnson541
committed
apply_solvent_correction in fix_barrier_height
mjohnson541
committed
enable solvent parameters to be directly specified in input file
mjohnson541
committed
adapt fix_barrier_height calls
mjohnson541
committed
handle ArrheniusChargeTransfer => Arrheniusq
mjohnson541
committed
add index of refraction to SolventData objects
mjohnson541
committed
fix KineticsModel outputs
mjohnson541
committed
add SoluteTSData object
mjohnson541
committed
add SoluteTSDIffData object
mjohnson541
committed
add function to convert SoluteData and SoluteTSDiffData to SoluteTSData
mjohnson541
committed
Enable database to understand new objects
mjohnson541
committed
Enable LibraryReaction to handle SoluteTSData
mjohnson541
committed
Enable TemplateReaction to handle new TS solvent corrections
mjohnson541
committed
only use kinetics that have arrhenius forms for tree generation
mjohnson541
committed
enable solute data to be pulled from further up the tree as necessary
mjohnson541
committed
enable fitting of TS solute rules
mjohnson541
committed
allow training reaction notebook to handle reactions without gas phase kinetics
mjohnson541
committed
fix arrhenius test
mjohnson541
committed
fix atomtype test
mjohnson541
committed
add is_lithium to fragment
mjohnson541
committed
handle charge properly in fragment smiles hack
mjohnson541
committed
skip nodes that are empty when pulling solute data
mjohnson541
committed
remove test that solvent is in initial species
mjohnson541
committed
adapt corrTest
mjohnson541
committed
update product template after generation
mjohnson541
committed
add Li adsorption to test data
mjohnson541
committed
add adsorptionLi.py to testing database
mjohnson541
committed
don't check collision limit for reactions without kinetics
mjohnson541
committed
skip coverage dependence checks for electrochem families
mjohnson541
committed
add additional special groups to skip sample molecule generation
mjohnson541
committed
fix charge handling in make sample molecule
mjohnson541
committed
Refactor some rate fitting in rule generation.

rwest
authored and
mjohnson541
committed
Minor refactor.

rwest
authored and
mjohnson541
committed
Fix ArrheniusBM.get_activation_energy unit test.

rwest
authored and
mjohnson541
committed
Consistently use T=298. K for fitting and evaluating Blowers-Masel rates.

rwest
authored and
mjohnson541
committed
Fixes and tweaks to Blowers Masel classes' fit_to_reactions methods.

rwest
authored and
mjohnson541
committed
modifed arrbm `fit_to_data` unit test

davidfarinajr
authored and
mjohnson541
committed
TEMPORARY: set database branch to lithium
mjohnson541
committed
fix atomtype charge checking
mjohnson541
committed
fix typo in database test
mjohnson541
committed

Commits on Jul 28, 2023

allow `cat` of regression diff to fail, print a warning instead
JacksonBurns
authored

RMG-Electrochem#2316mjohnson541 wants to merge 110 commits intomainReactionMechanismGenerator/RMG-Py:mainfrom electrochemReactionMechanismGenerator/RMG-Py:electrochemCopy head branch name to clipboard

Commits

Commits on Jul 27, 2023

Commits on Jul 28, 2023

RMG-Electrochem#2316
mjohnson541 wants to merge 110 commits intomainfrom
electrochem