Skip to content

Conversation

@kspieks
Copy link
Contributor

@kspieks kspieks commented Mar 15, 2021

This PR updates the documentation tabulating which levels of theory are supported by Arkane. It adds ωB97X-D3/def2-TZVP and B97-D3/def2-mSVP, which were added in RMG-database PR #459. It also adds ωB97M-V/def2-TZVPD to the Arkane documentation since this LoT was already in RMG-database.

Let's merge this PR once RMG-database PR #459 is merged.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2086 (74db90e) into master (5a65011) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
+ Coverage   47.58%   47.62%   +0.03%     
==========================================
  Files          89       89              
  Lines       23565    23565              
  Branches     6131     6131              
==========================================
+ Hits        11213    11222       +9     
+ Misses      11169    11163       -6     
+ Partials     1183     1180       -3     
Impacted Files Coverage Δ
arkane/encorr/ae.py 71.79% <0.00%> (-0.86%) ⬇️
arkane/encorr/bac.py 75.77% <0.00%> (-0.72%) ⬇️
rmgpy/molecule/draw.py 53.86% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a65011...74db90e. Read the comment docs.

Copy link
Contributor

@xiaoruiDong xiaoruiDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kevin. Looks good! One question: Do you know what is 'SOC (spin orbit corrections)? ' and how it plays a role in RMG?

I cannot merge RMG-Py PR and need to wait for @alongd.

@kspieks
Copy link
Contributor Author

kspieks commented Mar 17, 2021

@xiaoruiDong Good question. I double checked this with Colin. We don't have to add SOC after fitting using arkane/encorr/ae.py. The fit is done against reference data from ATcT, etc., which is an agglomeration of high-accuracy experimental/computational data, so SOC is implicit in that data.

@xiaoruiDong
Copy link
Contributor

@alongd The twin RMG-database PR is merged. Can you help merge this PR? Many thanks!

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Please rebase

@kspieks kspieks force-pushed the model_chem_documentation branch from 2142a77 to 74db90e Compare March 22, 2021 18:33
@kspieks
Copy link
Contributor Author

kspieks commented Mar 22, 2021

Looking good! Please rebase

Thanks for reviewing. I rebased the PR

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongd alongd merged commit 2bc36c0 into master Mar 23, 2021
@alongd alongd deleted the model_chem_documentation branch March 23, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants