-
Notifications
You must be signed in to change notification settings - Fork 250
Update model chemistry documentation #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb1affb to
2142a77
Compare
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
==========================================
+ Coverage 47.58% 47.62% +0.03%
==========================================
Files 89 89
Lines 23565 23565
Branches 6131 6131
==========================================
+ Hits 11213 11222 +9
+ Misses 11169 11163 -6
+ Partials 1183 1180 -3
Continue to review full report at Codecov.
|
xiaoruiDong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kevin. Looks good! One question: Do you know what is 'SOC (spin orbit corrections)? ' and how it plays a role in RMG?
I cannot merge RMG-Py PR and need to wait for @alongd.
|
@xiaoruiDong Good question. I double checked this with Colin. We don't have to add SOC after fitting using |
|
@alongd The twin RMG-database PR is merged. Can you help merge this PR? Many thanks! |
alongd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Please rebase
2142a77 to
74db90e
Compare
Thanks for reviewing. I rebased the PR |
alongd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR updates the documentation tabulating which levels of theory are supported by Arkane. It adds
ωB97X-D3/def2-TZVPandB97-D3/def2-mSVP, which were added in RMG-database PR #459. It also addsωB97M-V/def2-TZVPDto the Arkane documentation since this LoT was already in RMG-database.Let's merge this PR once RMG-database PR #459 is merged.