Fix a few bugs in the database test work #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Label checking is done as part of the isomorphism routines. Enforcing the isSpecificTypeOf and Equivalent methods to check it just breaks the isomorphism routines, as demonstrated by the two unit tests that started failing. (Yay for unit tests!)
Equivalent check needs to ensure the matches work both ways. isSpecificCaseOf only needs to check self is contained within other. (and both need to not just check self against self)
…Of tests. We check a variety of radicals, multiplicities, and charges. This helped find a bug I almost introduced :-) (and I think would have detected the ones I had just removed)
This was referenced Apr 2, 2014
nyee
added a commit
that referenced
this pull request
Apr 2, 2014
Fix a few bugs in the database test work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the changes in #196
broke the isomorphism unit tests, as discussed in that pull request thread.
This pull request hopefully fixes it, and adds a few more tests to the unit tests,
making them even harder to pass.
@nyee, please see if what I did matches what you intended.