-
Notifications
You must be signed in to change notification settings - Fork 250
Atom energy fitting #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom energy fitting #1950
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
=========================================
Coverage ? 46.40%
=========================================
Files ? 87
Lines ? 22973
Branches ? 5974
=========================================
Hits ? 10660
Misses ? 11169
Partials ? 1144
Continue to review full report at Codecov.
|
amarkpayne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for implementing this! I looked over the code for fitting again, and all of the math checks out. I'll go ahead begin a PR in ARC to utilize this functionality.
arkane/encorr/ae.py
Outdated
| in the electronic energy. | ||
|
|
||
| Args: | ||
| species_energies: Dictionary of species labels with single-point electronic energies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The energies are just floats, right? We should specify that the unit needs to be hartree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mention the units in the notes above. I'll add it here again.
Add atomization_energy, xyz_dict, and zpe.
Requires dictionary of species labels that match those in ae.py and their single-point energies.
fb5e765 to
9c85cc6
Compare
Motivation or Problem
We should fit atom energies so that levels of theory that produce incorrect atom energies can be used to compute thermochemistry.
Description of Changes
Added
AEandAEJobclasses that require a dictionary of species labels with single-point electronic energies (computed using the experimental geometries available in the reference database). For example,The list of species that has to be provided is available in
SPECIES_LABELSinarkane/encorr/ae.py. Atom energies can be fitted by using theae()function in Arkane input files as described in the updated documentation. Corresponding database PR is ReactionMechanismGenerator/RMG-database#415.Testing
Added unit tests and checked that it works well for wB97M-V.
Reviewer Tips
Check the logic of the linear regression and maybe run an Arkane job to fit energies.