add display css variable for html preview link#1412
Merged
Conversation
cocomarine
temporarily deployed
to
previews/1412/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CSS custom property hook to control the visibility/layout of the HTML runner “open in new tab” preview link.
Changes:
- Narrow the selector from
.htmlrunner-linktoa.htmlrunner-link. - Introduce
--editor-htmlrunner-link-displayto control the link’sdisplayvalue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cocomarine
temporarily deployed
to
previews/1412/merge
GitHub Actions
Inactive
cocomarine
temporarily deployed
to
previews/1412/merge
GitHub Actions
Inactive
Contributor
|
I assigned @mwtrew to review as he's currently looking at the HTML editor |
Contributor
|
Group reviewed and approved |
mwtrew
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
displayproperty to thea.htmlrunner-linkclass forHtmlRunner.This is to enable / disable the HTML preview link.
The link is currently broken in CCP due to the use of relative link for the preview and we would like to disable it until it gets fixed (hopefully in the issue https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1264)
Before:
After with
--editor-htmlrunner-link-display: none: