-
Notifications
You must be signed in to change notification settings - Fork 11
Configure project and asset APIs for Scratch #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
edd96f5
Make naming of api call handler arguments clearer
zetter-rpf 1d86e0f
Allow the setting of cookies when loading projects
zetter-rpf 8cc8625
Make the test page work whatever the host
zetter-rpf 97334e2
Set up scratch to use the new API routes
zetter-rpf a59aff4
Make the local scratch test work again
zetter-rpf b0d2d0a
Add in a button to save scratch projects
zetter-rpf 6e4e756
Error when require attributes are not set
zetter-rpf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <h1>You may be looking for...</h1> | ||
| <ul> | ||
| <li>Web Component test page <a href="http://localhost:3011/web-component.html">http://localhost:3011/web-component.html</a></li> | ||
| <li>Web Component test page <a href="/web-component.html">/web-component.html</a></li> | ||
| </ul> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import configureStore from "redux-mock-store"; | ||
| import { render, screen } from "@testing-library/react"; | ||
| import React from "react"; | ||
| import { Provider } from "react-redux"; | ||
| import ScratchContainer from "./ScratchContainer"; | ||
|
|
||
| describe("ScratchContainer", () => { | ||
| let originalAssetsUrl; | ||
|
|
||
| beforeEach(() => { | ||
| originalAssetsUrl = process.env.ASSETS_URL; | ||
| process.env.ASSETS_URL = "https://example.com"; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| process.env.ASSETS_URL = originalAssetsUrl; | ||
| }); | ||
|
|
||
| test("renders iframe with src built from project_id and api_url", () => { | ||
| const mockStore = configureStore([]); | ||
| const store = mockStore({ | ||
| editor: { | ||
| project: { | ||
| identifier: "project-123", | ||
| }, | ||
| scratchApiEndpoint: "https://api.example.com/v1", | ||
| }, | ||
| }); | ||
|
|
||
| render( | ||
| <Provider store={store}> | ||
| <ScratchContainer /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const iframe = screen.getByTitle("Scratch"); | ||
| expect(iframe).toBeInTheDocument(); | ||
|
|
||
| const url = new URL(iframe.getAttribute("src")); | ||
| expect(url.pathname).toBe("/scratch.html"); | ||
| expect(url.searchParams.get("project_id")).toBe("project-123"); | ||
| expect(url.searchParams.get("api_url")).toBe("https://api.example.com/v1"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/projects/blank-scratch.json → src/projects/cool-scratch.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.