-
Notifications
You must be signed in to change notification settings - Fork 11
Progress bar projects site refresh #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jamdelion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As discussed I think you can tackle the spacing at the bottom of the sidebar footer too (beneath progress bar).
The other thing I was thinking is that the design has structured the elements a little differently in terms of spacing. The overall result looks basically the same, but often I like to try and make sure I match structurally:
(i.e. having the gaps between elements).
Yours currently is:
adrian-rpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on codebase consistency
| @@ -1,19 +1,42 @@ | |||
| @use './rpf_design_system/spacing' as *; | |||
| @use "./rpf_design_system/spacing" as *; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codebase standard is '
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds additional styling hooks and UI elements to the Instructions Panel progress bar to support a refreshed “projects” step navigation design.
Changes:
- Adds a step counter element above the progress bar.
- Introduces new CSS custom properties for progress bar color, step button radius, and toggling the step counter’s display.
- Updates the step navigation buttons to use the secondary button style and adjusts layout structure for the progress region.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/Menus/Sidebar/InstructionsPanel/ProgressBar/ProgressBar.jsx | Adds step counter markup and restructures the progress bar layout; updates button styling. |
| src/assets/stylesheets/ProgressBar.scss | Adds CSS variables for theming and button radius; styles the new step counter and progress container layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <p className="step-counter">{`${ | ||
| currentStepPosition + 1 | ||
| } of ${numberOfSteps}`}</p> |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new step counter string is hard-coded ("of") and bypasses i18n, so it will remain English in non-English locales. Consider adding a translation key (e.g. instructionsPanel.stepCounter with interpolation for current/total) and rendering it via t(...) instead of a template literal.
| <p className="step-counter">{`${ | |
| currentStepPosition + 1 | |
| } of ${numberOfSteps}`}</p> | |
| <p className="step-counter"> | |
| {t("instructionsPanel.stepCounter", { | |
| current: currentStepPosition + 1, | |
| total: numberOfSteps, | |
| })} | |
| </p> |
| <p className="step-counter">{`${ | ||
| currentStepPosition + 1 | ||
| } of ${numberOfSteps}`}</p> | ||
| <progress max={numberOfSteps - 1} value={currentStepPosition} /> |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new step counter behavior isn't covered by the existing ProgressBar unit tests. Since there is already a dedicated ProgressBar.test.js, it would be good to add an assertion that the counter renders the correct current/total (and, if you switch to i18n, that it uses the translated string).
| border-radius: var(--step-buttons-radius, inherit); | ||
| &:hover, | ||
| &:focus, | ||
| &:active { | ||
| border-radius: var(--step-buttons-radius, inherit); |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-radius: var(--step-buttons-radius, inherit) overrides the default .btn border radius even when the CSS var isn't set (it will inherit from the parent, likely resulting in 0). If the intent is to keep the existing button rounding by default, use the same fallback as Button.scss (e.g. $space-0-5) or otherwise avoid overriding when the variable is unset.
| border-radius: var(--step-buttons-radius, inherit); | |
| &:hover, | |
| &:focus, | |
| &:active { | |
| border-radius: var(--step-buttons-radius, inherit); | |
| border-radius: var(--step-buttons-radius, $space-0-5); | |
| &:hover, | |
| &:focus, | |
| &:active { | |
| border-radius: var(--step-buttons-radius, $space-0-5); |
| display: var(--display-step-counter, none); | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin: 0 0 0 0; |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: margin: 0 0 0 0; can be simplified to margin: 0; for readability.
| margin: 0 0 0 0; | |
| margin: 0; |
Adding some more vars to customise the progress bar/step navigation in the Instructions Panel:
--progress-bar-color- sets the colour of the progress bar, if not set, defaults to the value of--editor-color-theme--step-buttons-radius- sets the border radius of step navigation buttons (used in projects ui to make circular buttons)--display-step-counter- used to display the step counter added in this PR. default to none, setting toflexwill display the step counter above the progress barExample of all of these in use in projects-ui
Before:

After:
