Fixing the append file write mode #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
temporarily deployed
to
previews/1200/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1200/merge
GitHub Actions
Inactive
danhalson
reviewed
Mar 24, 2025
Contributor
There was a problem hiding this comment.
are there any tests around this?
Contributor
Author
There was a problem hiding this comment.
there aren't I'm afraid, only ones on the UI side, but that's not really testing the inner workings of pyodide
danhalson
approved these changes
Mar 24, 2025
Contributor
danhalson
left a comment
danhalson
left a comment
There was a problem hiding this comment.
LGTM (would be good to get some tests in but this shouldn't slow down getting this bug fix out there)
Merged
loiswells97
added a commit
that referenced
this pull request
Apr 15, 2025
### Added - `editor-projectLoadFailed` custom event that fires when a project completely fails to load (#1201) - Added runnerBeingLoaded state to prevent race condition overwrites (#1205) ### Fixed - Bugs in append mode for writing to files in python (#1200) - `turtle` bug that did not display output on first code run (#1203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
pyodideside - it was always usingwrather than the mode provided in the code