fix: Fix bug that caused blocks to skip valid destinations when moving with looping disabled#9894
Open
gonfunko wants to merge 2 commits into
Open
fix: Fix bug that caused blocks to skip valid destinations when moving with looping disabled#9894gonfunko wants to merge 2 commits into
gonfunko wants to merge 2 commits into
Conversation
…g with looping disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9882
Proposed Changes
This PR fixed a bug that caused moving blocks in constrained mode to skip valid destinations when navigation looping was disabled. The check for whether a block was in a terminal position, i.e. unattached on the workspace above or below all other blocks with valid connections, was only checking connections on top-level blocks to see if the block in question could connect. It now checks all connections in each block stack.