fix: remove eslint dependency from dev-scripts#2682
Merged
maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom Apr 2, 2026
Merged
fix: remove eslint dependency from dev-scripts#2682maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom
maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom
Conversation
mikeharv
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes conflicts with dependencies because dev-scripts was bringing along an unused old copy of eslint
Proposed Changes
dev-scripts. We already removed the script that actually ran eslint and we deleted the@blockly/eslint-configplugin a while ago, so this was installing the deprecated version from npmblockly-scripts lintscript from thedev-createtemplate (since that script hasn't existed for a while)Note: to correctly lint any plugins in
blockly-samplesyou just runnpm run lintat the root. So individual plugins do not need the script. For third-party plugins, authors should set up their own linting without having to worry about the blockly team's style guide. This is not changing, this has already been the situation for a whileReason for Changes
I've been having to force install some deps when using keyboard-navigation plugin because the plugin uses eslint 8 while devscript was "using" (depending on but not actually using) eslint 7
Test Coverage
¯\_(ツ)_/¯
Documentation
I don't think so
Additional Information