chore: Update turtle demo for v12 #2634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes issue 2628.
Proposed Changes
Makes the following fixes to address the problems in the bug:
Sets the cursor using CSS.
FieldTurtle, removes theCURSORfield, removesupdateEditable()(which only set the cursor), and adds aturtleFieldclass for greater specificity.Updates CSS names for v12: Changes
blocklyEditableTexttoblocklyEditableFieldandblocklyNonEditableTexttoblocklyNonEditableField.In the CSS file, deletes
.blocklyNonSelectable(removed in v12) and moves its rules tocustomFieldsTurtleWidget.Makes the following changes, which address other problems:
Replaces call to
Block.setEnabled(removed in v12) with call toBlock.setDisabledReason.Fixes the final set of CSS selectors, which weren't being applied because the
textselector was less specific than the.blocklyTextselector in.geras-renderer.classic-theme .blocklyText, which comes fromrenderers/common/constants.ts. As a result, the fill was set to#fffinstead of#000, which the final set of selectors attempted to apply.Reason for Changes
Test Coverage
Tested manually
Documentation
N/A
Additional Information