Include Cargo.lock for improved stability of old versions moving forward#474
Merged
Ralith merged 1 commit intoRalith:masterfrom Jan 23, 2026
Merged
Include Cargo.lock for improved stability of old versions moving forward#474Ralith merged 1 commit intoRalith:masterfrom
Ralith merged 1 commit intoRalith:masterfrom
Conversation
Collaborator
Author
|
I was so confused by the CI failures, and then I realized that I forgot update the master branch in my fork after merging #463. Whoops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, compiling the v0.1.0 tag of this repo is nontrivial due to unexpected breakages in minor package updates (specifically zstd). If the dependencies were pinned, future viewers of this repo would be more likely to be able to compile older versions of Hypermine.
This may also avoid breakage caused by different people developing Hypermine with different versions of various dependencies, breaking builds for other people until they delete and regenerate Cargo.lock on their end.
(Based on a conversation from Discord from about a year ago)
I've also added "--locked" as an option to all the relevant cargo commands now that this lockfile is present.
Note that I created this PR by deleting and regenerating my own Cargo.lock file, so as far as I know, the packages in it are as up-to-date as possible given the package requirements.