Skip to content

feat[STM32][SPI]: add interrupt transfer mode support#11367

Closed
wdfk-prog wants to merge 2 commits intoRT-Thread:masterfrom
wdfk-prog:05-stm32-spi
Closed

feat[STM32][SPI]: add interrupt transfer mode support#11367
wdfk-prog wants to merge 2 commits intoRT-Thread:masterfrom
wdfk-prog:05-stm32-spi

Conversation

@wdfk-prog
Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

当前 STM32 SPI 驱动主要依赖轮询和 DMA 传输路径,缺少统一的中断传输模式配置与调度入口。不同 SPI 实例的 DMA/IRQ 配置宏也较分散,后续扩展和维护成本较高。

本 PR 用于补充 SPI 中断传输模式,并整理 STM32 SPI 驱动的传输方式配置层级,使 POLL、DMA、INT 相关能力可以按 TX/RX 和具体 SPI 实例统一派生。

你的解决方案是什么 (what is your solution)

  • drv_spi.h 中增加 STM32 SPI POLL、DMA、INT、IRQ 相关聚合宏,统一判断各 SPI 实例的传输能力。
  • 将 SPI DMA 标志切换为 RT-Thread 设备标志位,例如 RT_DEVICE_FLAG_DMA_RXRT_DEVICE_FLAG_DMA_TXRT_DEVICE_FLAG_INT_RXRT_DEVICE_FLAG_INT_TX
  • spixfer() 中增加 DMA/INT/POLL 路由逻辑,默认小于 32 字节使用轮询,较长传输优先使用 DMA,中断模式作为可配置的异步传输路径。
  • 增加 SPI 异步传输完成等待、超时 abort 和错误回调处理。
  • 补充 SPI1 到 SPI6 的 IRQ 条件编译处理,并新增 SPI6 IRQ handler。
  • 将 DMA setup、rollback 和 DMA handle 成员按 RX/TX DMA 配置宏分别保护,减少无 DMA 配置场景下的无效依赖。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: F4。
  • .config: BSP_USING_SPIxBSP_SPIx_RX_USING_DMABSP_SPIx_TX_USING_DMABSP_SPIx_RX_USING_INTBSP_SPIx_TX_USING_INT
  • action: 未在当前上下文中提供 action 编译链接,提交前需补充对应 PR 分支的成功编译链接。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

wdfk-prog added 2 commits May 6, 2026 17:26
refine the stm32 hard spi dma configuration hierarchy with shared feature macros

align dma flag usage with rt-device dma flags and gate dma-only fields and paths

make the dma transfer threshold configurable through BSP_SPI_DMA_TRANS_MIN_LEN
introduce interrupt transfer route selection and SPI IRQ visibility macros
unify DMA and INT completion handling with timeout-triggered abort recovery
keep short transfers on polling and use DMA or INT only when eligible
refine STM32 SPI init and IRQ registration paths for mixed transfer backends
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:05-stm32-spi
  • 设置PR number为 \ Set the PR number to:11367
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 05-stm32-spi 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the 05-stm32-spi branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.h

📊 Current Review Status (Last Updated: 2026-05-06 21:13 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@wdfk-prog wdfk-prog changed the title 本地三轮审查总结 feat[STM32][SPI]: 添加 SPI 中断传输模式支持 May 6, 2026
@wdfk-prog wdfk-prog changed the title feat[STM32][SPI]: 添加 SPI 中断传输模式支持 feat[STM32][SPI]: add interrupt transfer mode support May 6, 2026
@wdfk-prog wdfk-prog closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant