Skip to content

[bsp](stm32h7)修复了fdcan驱动的一些bug#11257

Open
takuya60 wants to merge 1 commit intoRT-Thread:masterfrom
takuya60:master
Open

[bsp](stm32h7)修复了fdcan驱动的一些bug#11257
takuya60 wants to merge 1 commit intoRT-Thread:masterfrom
takuya60:master

Conversation

@takuya60
Copy link

@takuya60 takuya60 commented Mar 16, 2026

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

我在使用stm32H7的fdcan驱动时遇到了无法发送与接收的问题,并且发现没有ISO-CANFD常用的5M速率

你的解决方案是什么 (what is your solution)

1.解决了发送数据时没有对是否进行数据位加速(BRS)进行判断的问题,新增了一个if判断,判断上层传来的pmsg->brs,如果是1,则把TxHeader.BitRateSwitch置为FDCAN_BRS_ON;如果是0,则置为FDCAN_BRS_OFF

2.解决了在数据接收时对数据位数判断错误,原来是直接把RxHeader.DataLength,这样只能传入0-15这几个数,所以需要做对应的转换,比如把15转换成64,代表实际上有64位数据。在开头新增了字节数查询表的函数

  1. 在stm32_fdcan_timing_t st_FDCAN_DataTiming中新增了ISO-CANFD常用的5M速率

4.新增发送延迟补偿配置,防止高速率(>2M)下传输出错

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    \rt-thread\bsp\stm32\libraries\HAL_Drivers\drivers\drv_fdcan.c

  • .config:

https://gitee.com/User_lwh/fes/tree/master/04_Software/04_STM32H7B0/project

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:master
  • 设置PR number为 \ Set the PR number to:11257
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 master 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Mar 16, 2026
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_fdcan.c

📊 Current Review Status (Last Updated: 2026-03-17 00:05 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


takuyasaya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants