Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-01 17:08 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR adds Device Manager (DM) support to the PHY driver subsystem and fixes a critical infinite loop bug in the PHY auto-negotiation timeout logic.
Key Changes:
- Critical bug fix: Added missing counter increment (
i += 100) to prevent infinite loop during PHY auto-negotiation timeout waiting - DM integration: Updated Kconfig to support DM-based PHY configuration through osource mechanism
- Header fix: Extended PHY header inclusion to support both
RT_USING_PHYandRT_USING_PHY_V2configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
components/drivers/phy/general.c |
Fixed critical infinite loop bug by adding counter increment; improved log message consistency using LOG_I/LOG_E/LOG_D macros |
components/drivers/phy/Kconfig |
Changed to menuconfig format and added osource directive for DM-based PHY driver configuration |
components/drivers/phy/ofw.c |
Changed debug log level from DBG_INFO to DBG_LOG for better log output control |
components/drivers/include/rtdevice.h |
Extended conditional include to support RT_USING_PHY_V2 in addition to RT_USING_PHY |
拉取/合并请求描述:(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up