Conversation
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_driver_canReviewers: wdfk-prog Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-02 11:40 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
There was a problem hiding this comment.
Pull request overview
This PR adds Device Manager (DM) support for CAN drivers in RT-Thread. The implementation introduces DM-specific APIs and configuration options to enable BSP-level customization of CAN controllers.
Key changes:
- New DM API files providing CAN/CAN-FD data length conversion utilities
- Conditional build system integration for DM support
- BSP-level Kconfig extensibility through environment variable
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| components/drivers/can/can_dm.h | New header defining CAN/CAN-FD constants and DLC conversion function declarations for DM support |
| components/drivers/can/can_dm.c | New implementation providing DLC-to-length and length-to-DLC conversion utilities for CAN FD |
| components/drivers/can/SConscript | Updated to conditionally exclude can_dm.c when RT_USING_DM is not enabled |
| components/drivers/can/Kconfig | Changed to menuconfig and added osource directive for BSP-specific DM CAN configuration |
1. Kconfig import wtih DM 2. Add DM API for Drivers Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
@Rbb666 AI 要求问题已经修改 |
2 participants
拉取/合并请求描述：(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up