Conversation
1. Fixup some LOG_D args. 2. Stop installing page when `rt_aspace_map_phy` fail. Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-02 12:10 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR updates the RT-Thread MM (Memory Management) system with three main improvements: adding support for dynamic page MPR (Memory Page Region) size, fixing LOG_D argument mismatches, and preventing page installation when physical address mapping fails.
Key Changes
- Dynamic MPR Size Support: Introduces
RT_PAGE_MPR_SIZE_DYNAMICconfiguration option to support platforms where virtual address width is determined at runtime rather than compile-time - Bug Fixes: Corrects several LOG_D format string arguments that referenced undefined variables and fixes a macro parameter name mismatch
- Error Handling: Adds a check to skip page installation when
rt_aspace_map_phyfails, preventing potential system issues
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| components/mm/Kconfig | Adds new RT_PAGE_MPR_SIZE_DYNAMIC configuration option for platforms with runtime-determined virtual address width |
| components/mm/mm_page.h | Implements conditional compilation for dynamic vs static MPR size, defining rt_mpr_size_dynamic() function when dynamic mode is enabled |
| components/mm/mm_page.c | Refactors MPR_SIZE calculation into a macro and implements rt_mpr_size_dynamic() function; fixes LOG_D argument using undefined page_nr variable |
| components/mm/mm_memblock.c | Fixes LOG_D arguments using undefined variables (base, size, flag → start, end, flags); adds error checking to skip page installation on mapping failure |
| components/mm/mm_aspace.c | Fixes macro _IS_OVERSIZE to use correct parameter names (limit_s, limit_sz instead of limit_start, limit_size) |
For RISC-V or dynamic address space arch in the future. Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
@Rbb666 AI 相关问题已修改 |
* [MM] Fixup MM 1. Fixup some LOG_D args. 2. Stop installing page when `rt_aspace_map_phy` fail. * [MM] Support page MPR dynamic size For RISC-V or dynamic address space arch in the future. Signed-off-by: GuEe-GUI <2991707448@qq.com>
2 participants
拉取/合并请求描述：(PR description)
[
rt_aspace_map_phyfail.]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up