[kernel]rt_thread_suspend_to_list函数补充 by Kurngsy · Pull Request #10963 · RT-Thread/rt-thread

Kurngsy · 2025-11-19T10:28:29Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

作为一个rtthread的初学者，对该函数的实现产生了疑惑，尤其是if (stat == RT_THREAD_SUSPEND)部分，当一线程用该函数试图挂起其他线程时（注释中已说明禁止）该函数将返回OK，因为很多情况下一线程运行时其他线程都是被延时挂起让出的。在阅读了函数注释后我猜测项目组原本的意图可能为以下之一：
。该函数本身具有较高权限能挂起其他线程，所以注释警告不应如此做
。该函数在本身只能挂起自身不能挂起其他线程，所以注释说明并报错
。该函数只考虑了挂起自身的情况挂起其他线程可能会未知错误，所以注释警告
但是现在的函数实现不属于以上情况，不应仅返回OK ，且不应存在挂起后挂起（在旧版本为断言），说明函数设置了余量来应对用户行为，以下是对余量的进一步补充

你的解决方案是什么 (what is your solution)

。区分挂起与延迟挂起，挂起应重置计时器，并在覆盖时报告。
。将挂起状态按照rtdef细分NTERRUPTIBLE, KILLABLE, UNINTERRUPTIBLE，并可使挂起状态升级。

请提供验证的bsp和config (provide the config and bsp)

BSP: rt-thread-master\bsp\nxp\imx\imxrt\imxrt1064-nxp-evk
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

CLAassistant · 2025-11-19T10:28:36Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Kurngsy
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2025-11-19T10:28:37Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：master
设置PR number为 \ Set the PR number to：10963

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-11-19T10:28:39Z

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)

src/thread.c

📊 Current Review Status (Last Updated: 2025-11-21 17:26 CST)

⌛ GorrayLi Pending Review
✅ ReviewSun Reviewed On 2025-11-19 18:40 CST
⌛ hamburger-os Pending Review
⌛ lianux-mm Pending Review
⌛ wdfk-prog Pending Review
⌛ xu18838022837 Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

ReviewSun · 2025-11-19T10:40:51Z

LGTM

Rbb666 · 2025-11-20T01:56:05Z

作者可以看下这个PR，以及相关描述：
修改主要是因为社区有挂起其他线程的需求，但是本身这个行为就是需要可控的，否则一个线程去挂起其他线程会出现问题，这个在rt_thread_suspend的API注释也有体现。所以仅仅是提供了可以去挂起其他线程的一种方法，避免了会出现断言的情况。
因此我不建议再把断言再次加回来的。

#10660

Kurngsy · 2025-11-20T05:49:30Z

@Rbb666 已修改，我之前理解得不对

Copilot

Pull Request Overview

This PR aims to enhance the rt_thread_suspend_to_list function in the RT-Thread kernel by improving its behavior when handling already-suspended threads. The changes introduce logic to stop timers when re-suspending threads, allow suspend state upgrades (from INTERRUPTIBLE to KILLABLE/UNINTERRUPTIBLE), and restore an assertion to check that only the current thread can suspend itself when in RUNNING state. Most of the changes are code formatting improvements to align with RT-Thread coding standards.

Key Changes

Enhanced already-suspended thread handling with timer stopping and suspend flag upgrading
Restored self-suspension assertion for RUNNING state threads
Code formatting improvements throughout the file (spacing, alignment)

src/thread.c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Map suspend_flag to corresponding thread suspend state values and update suspend state if stricter flag is requested.

Rbb666 · 2025-11-21T06:43:11Z

src/thread.c

    rt_sched_unlock_n_resched(slvl);
 }

 static rt_err_t _thread_init(struct rt_thread *thread,


这个PR不建议格式化除了修改部分的内容，要不然review很麻烦

👀好，第一次提大项目PR

Rbb666 · 2025-11-21T06:45:20Z

src/thread.c

+        else
        {
-            rt_err_t rt_err = -RT_EINVAL;
-


为啥要改这块内容？

ReviewSun · 2025-11-21T09:30:56Z

commit太多了麻烦重新提交一下？

Kurngsy added 2 commits November 19, 2025 17:31

Additional details

3f2c97d

Merge branch 'master' of https://github.com/Kurngsy/rt-thread

070e295

github-actions bot added the Kernel PR has src relate code label Nov 19, 2025

style: format code with clang-format [skip ci]

01415b8

修改了部分错误逻辑，并使函数有更高权限

bf41b81

Rbb666 requested review from Guozhanxin, Rbb666 and Copilot November 20, 2025 09:43

Copilot started reviewing on behalf of Rbb666 November 20, 2025 09:44 View session

Copilot finished reviewing on behalf of Rbb666 November 20, 2025 09:46

Copilot AI reviewed Nov 20, 2025

View reviewed changes

Kurngsy and others added 7 commits November 20, 2025 17:52

Update src/thread.c

daf3b4e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/thread.c

0d6232f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/thread.c

c2fc9a7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/thread.c

4a6b1ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/thread.c

03881b0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Implement thread suspend state mapping logic

31a9804

Map suspend_flag to corresponding thread suspend state values and update suspend state if stricter flag is requested.

Refactor suspend state update comment for clarity

ddc6dc5

Rbb666 reviewed Nov 21, 2025

View reviewed changes

Kurngsy added 2 commits November 21, 2025 17:24

Refactor thread.c for code consistency and clarity

0877515

Fix formatting of if statement in thread.c

f317ee7

Kurngsy requested a review from Rbb666 November 21, 2025 09:30

Kurngsy closed this Nov 21, 2025

Conversation

Kurngsy commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

CLAassistant commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: kernel

📊 Current Review Status (Last Updated: 2025-11-21 17:26 CST)

📝 Review Instructions

Uh oh!

ReviewSun commented Nov 19, 2025

Uh oh!

Rbb666 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kurngsy commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rbb666 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Kurngsy Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Rbb666 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

ReviewSun commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kurngsy commented Nov 19, 2025 •

edited

Loading

CLAassistant commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

Rbb666 commented Nov 20, 2025 •

edited

Loading