fix(drv_can): Suppress unused variable warning in send error path && docs(drv_gpio): Add detailed Doxygen comments for GET_PIN macro#10947
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_stm32Reviewers: @Liang1795 @hamburger-os @wdfk-prog Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-11-20 09:08 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two separate improvements to STM32 HAL drivers: (1) suppressing an unused variable compiler warning in the CAN driver's error path, and (2) adding comprehensive Doxygen documentation for the GET_PIN macro in the GPIO driver to improve code maintainability.
- Fixes unused variable warning in drv_can.c by marking
mailbox_maskas intentionally unused - Adds detailed Doxygen comments documenting the GET_PIN macro's functionality, parameters, usage examples, and platform-specific behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bsp/stm32/libraries/HAL_Drivers/drivers/drv_can.c | Suppresses unused variable warning for mailbox_mask in CAN send error path |
| bsp/stm32/libraries/HAL_Drivers/drivers/drv_gpio.h | Adds comprehensive Doxygen documentation block for GET_PIN macro |
c6c9f82 to
d55360d
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up