bsp: k230: add spi driver by ChuanN-sudo · Pull Request #10917 · RT-Thread/rt-thread

ChuanN-sudo · 2025-11-10T15:34:46Z

Continue from #10885
增加了对于spi和qspi两种调用方式的支持，在utest里增加了相关测试demo；
kconfig中从qspi改为spi，增添了对于时钟速度和支持模式的说明；
按照 #10885的comment提到的改动建议进行了修改

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have an spi driver.

Solution: Provide spi driver for the k230 platform in the RT-Thread repository.

-Supports SPI0(OSPI) controller with 1/2/4/8 data lines.
-Supports SPI1(QSPI0) and SPI2(QSPI1) controllers with 1/2/4 data lines.
-Implements DMA-based transfers for OSPI, QSPI, and DSPI modes.
-Falls back to standard IRQ-driven transfers for legacy SPI mode (single line).
-Driver support for input SPI-related structures and QSPI-related structures.

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

为K230添加spi驱动

你的解决方案是什么 (what is your solution)

添加spi驱动

请提供验证的bsp和config (provide the config and bsp)

BSP:/bsp/k230/drivers/interdrv/spi
.config:
action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-11-10T15:34:55Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：k230_spi_driver
设置PR number为 \ Set the PR number to：10917

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 k230_spi_driver 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the k230_spi_driver branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-11-10T15:34:59Z

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: unicornx

Changed Files (Click to expand)

bsp/k230/.ci/attachconfig/ci.attachconfig.yml
bsp/k230/.config
bsp/k230/board/Kconfig
bsp/k230/drivers/interdrv/spi/SConscript
bsp/k230/drivers/interdrv/spi/drv_spi.c
bsp/k230/drivers/interdrv/spi/drv_spi.h
bsp/k230/drivers/utest/SConscript
bsp/k230/drivers/utest/test_spi.c
bsp/k230/rtconfig.h

📊 Current Review Status (Last Updated: 2025-11-16 11:22 CST)

⌛ unicornx Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copilot

Pull Request Overview

This PR adds SPI driver support for the K230 platform, providing the capability to use SPI0 (OSPI), SPI1 (QSPI0), and SPI2 (QSPI1) controllers. The driver supports both standard SPI and QSPI modes with 1/2/4/8 data lines, implements DMA-based transfers for multi-line modes, and falls back to IRQ-driven transfers for legacy single-line SPI mode.

Key Changes:

New SPI driver implementation supporting multiple data line configurations (1/2/4/8 lines)
DMA-based transfer support for high-speed multi-line modes
IRQ-driven transfer fallback for standard SPI mode
Support for both rt_spi_device and rt_qspi_device structures

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
bsp/k230/drivers/interdrv/spi/drv_spi.c	Core SPI driver implementation with configure, transfer, and IRQ handling functions
bsp/k230/drivers/interdrv/spi/drv_spi.h	SPI register definitions and hardware configuration macros
bsp/k230/drivers/utest/test_spi.c	Unit tests demonstrating both SPI and QSPI device usage
bsp/k230/board/Kconfig	Configuration options for enabling SPI0/SPI1/SPI2 controllers
bsp/k230/drivers/utest/SConscript	Build script integration for SPI test cases
bsp/k230/.ci/attachconfig/ci.attachconfig.yml	CI configuration for SPI testing
bsp/k230/.config	Updated configuration file with new package options
bsp/k230/rtconfig.h	Added HPMicro SDK section

bsp/k230/drivers/interdrv/spi/drv_spi.c

bsp/k230/drivers/utest/test_spi.c

Rbb666 · 2025-11-13T01:56:28Z

此pr也麻烦更新到这个表单：https://github.com/RT-Thread/rt-thread/blob/master/bsp/README.md

unicornx

有一些小问题请再看一下，其他 LGTM

unicornx · 2025-11-13T13:39:23Z

bsp/k230/board/Kconfig

+
+        if BSP_USING_SPI
+            config BSP_USING_SPI0
+                bool "Enable SPI0(OSPI controller support 1, 2, 4 and 8 lines, Max clock frequency is 200Mhz)"


菜单项的 TEXT 部分太长了，大量的解释可以放到 Kconfig 的 help 中
另外，避免 OSPI 和 QSPI0， QSPI1 这些说法，这个不是标准的描述

综上，以 SPI0 为例可以写成：

bool “Enable SPI0” help Support 1, 2, 4 and 8 lines. Max clock frequency is 200Mhz.

unicornx · 2025-11-13T13:42:30Z

bsp/k230/drivers/interdrv/spi/drv_spi.h

+    /* Transfer Done Clear Interrupt Clear Register              (0x134)*/
+    volatile uint32_t donecr;
+#endif
+    /* resv                                                      (0x138 ~ 0x13c)*/


resv 是什么意思？不要用缩写，请写全

已完善注释

unicornx · 2025-11-15T00:50:29Z

@Rbb666 please have a review, thanks.

Rbb666 · 2025-11-15T06:16:56Z

ci有编译报错，请修复下：

Rbb666 · 2025-11-15T06:17:18Z

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.

bsp/k230/board/Kconfig

bsp/k230/drivers/interdrv/spi/drv_spi.c

bsp/k230/drivers/utest/SConscript

bsp/k230/drivers/interdrv/spi/drv_spi.c

bsp/k230/board/Kconfig

ChuanN-sudo · 2025-11-15T08:20:06Z

您那边ci的编译报错我这边显示是warning，现已修改。copilot找到的问题也修改了

Rbb666 · 2025-11-16T02:27:19Z

您那边ci的编译报错我这边显示是warning，现已修改。copilot找到的问题也修改了

好的，等待CI通过后就可以合并了

Rbb666 · 2025-11-16T02:49:31Z

bsp/k230/drivers/interdrv/spi/drv_spi.c

+    }
+    if (qspi_cfg_parent->data_width < 4 || qspi_cfg_parent->data_width > 32)
+    {
+        return RT_EINVAL;


85，89，114，136 行应该返回负值

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have an spi driver. Solution: Provide spi driver for the k230 platform in the RT-Thread repository. - Supports SPI0(OSPI) controller with 1/2/4/8 data lines. - Supports SPI1(QSPI0) and SPI2(QSPI1) controllers with 1/2/4 data lines. - Implements DMA-based transfers for OSPI, QSPI, and DSPI modes. - Falls back to standard IRQ-driven transfers for legacy SPI mode (single line). - Updates documentation in bsp/README.md Signed-off-by: ChuanN-sudo <fjchuanil@gmail.com>

github-actions bot added the BSP label Nov 10, 2025

Rbb666 requested review from Copilot and unicornx November 11, 2025 02:35

Copilot started reviewing on behalf of Rbb666 November 11, 2025 02:35 View session

Copilot finished reviewing on behalf of Rbb666 November 11, 2025 02:36

Copilot AI reviewed Nov 11, 2025

View reviewed changes

ChuanN-sudo force-pushed the k230_spi_driver branch from 51d89ea to 948810e Compare November 11, 2025 03:31

ChuanN-sudo force-pushed the k230_spi_driver branch 5 times, most recently from 607ea32 to f3820f1 Compare November 13, 2025 03:40

unicornx suggested changes Nov 13, 2025

View reviewed changes

ChuanN-sudo force-pushed the k230_spi_driver branch from f3820f1 to e483cf2 Compare November 13, 2025 16:08

ChuanN-sudo requested a review from unicornx November 14, 2025 01:57

unicornx approved these changes Nov 15, 2025

View reviewed changes

unicornx requested a review from Rbb666 November 15, 2025 00:50

Rbb666 approved these changes Nov 15, 2025

View reviewed changes

Rbb666 requested a review from Copilot November 15, 2025 06:17

Copilot started reviewing on behalf of Rbb666 November 15, 2025 06:18 View session

Copilot finished reviewing on behalf of Rbb666 November 15, 2025 06:21

Copilot AI reviewed Nov 15, 2025

View reviewed changes

ChuanN-sudo force-pushed the k230_spi_driver branch from e483cf2 to b0cc531 Compare November 15, 2025 08:18

ChuanN-sudo requested a review from Rbb666 November 15, 2025 08:21

Rbb666 reviewed Nov 16, 2025

View reviewed changes

ChuanN-sudo force-pushed the k230_spi_driver branch from b0cc531 to 972daa9 Compare November 16, 2025 03:22

ChuanN-sudo requested a review from Rbb666 November 16, 2025 03:32

Rbb666 merged commit ae2a575 into RT-Thread:master Nov 16, 2025
30 checks passed

Conversation

ChuanN-sudo commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Nov 10, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_k230

📊 Current Review Status (Last Updated: 2025-11-16 11:22 CST)

📝 Review Instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rbb666 commented Nov 13, 2025

Uh oh!

unicornx left a comment

Choose a reason for hiding this comment

Uh oh!

unicornx Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

ChuanN-sudo Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

unicornx Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

ChuanN-sudo Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

unicornx commented Nov 15, 2025

Uh oh!

Rbb666 commented Nov 15, 2025

Uh oh!

Rbb666 commented Nov 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChuanN-sudo commented Nov 15, 2025

Uh oh!

Rbb666 commented Nov 16, 2025

Uh oh!

Rbb666 Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

ChuanN-sudo Nov 16, 2025

ChuanN-sudo commented Nov 10, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading