[fix][bsp/renesas][rsoc]: add i2c configuration dependency#10822
[fix][bsp/renesas][rsoc]: add i2c configuration dependency#10822Rbb666 merged 1 commit intoRT-Thread:v5.2.2-betafrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: @kurisaW Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-16 13:20 CST)
📝 Review Instructions
|
|
PR标题修改下,添加上“BSP”/“renesas”关键字,需要说清晰修复了什么问题 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation error in the Renesas RA8D1 vision board BSP by adding a missing dependency in the Kconfig configuration. The issue was that enabling hardware I2C in the BSP didn't automatically enable the RT-Thread I2C device driver framework, causing 19 compilation errors.
- Adds
select RT_USING_I2Cto the hardware I2C configuration option - Resolves the requirement to manually enable I2C drivers in both Hardware Drivers Config and RT-Thread Components menus
| menuconfig BSP_USING_HW_I2C | ||
| bool "Enable hardware I2C BUS" | ||
| default n | ||
| select RT_USING_I2C |
There was a problem hiding this comment.
[best_practices/最佳实践]: The added dependency select statement correctly resolves the compilation issue. This follows RT-Thread best practices for BSP Kconfig dependencies.
English: The addition of select RT_USING_I2C properly ensures that when hardware I2C is enabled at the BSP level, the corresponding RT-Thread I2C device driver framework is automatically enabled. This prevents the compilation errors and follows the correct dependency pattern.
中文:添加 select RT_USING_I2C 正确地确保了当在 BSP 层启用硬件 I2C 时,相应的 RT-Thread I2C 设备驱动框架会自动启用。这可以防止编译错误并遵循正确的依赖模式。
@Rbb666 AI可不可以直接总结PR内容,然后给出标题啊,这种机制能不能实现,也好统一后续版本日志的工作,到时候就能顺着让AI来总结版本日志了 |
那得找一个免费的AI,copilot是花钱的 |
|
在请求触发copliot的时候生成一条标题修改建议评论,这种是不是应该可以实现 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
编译报错19error,初步判断为RT_USING_IIC没有打开,menuconfig里面要想打开IIC需要同时在 Hardware Drivers Config → On-chip Peripheral Drivs和RT-Thread Components → Device Drirs同时打开IIC
你的解决方案是什么 (what is your solution)
解决办法为在Kconfig的IIC部分加上select Using I2C device drivers
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up