Conversation
The original project display was completely flat, now it is organized into a tree-like hierarchical structure based on the layout of the code. mm & tmpfs test are still keep as pervious bcos we have not move the source for these two components. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_libcReviewers: GorrayLi mysterywolf Changed Files (Click to expand)
🏷️ Tag: kernelReviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837 Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-16 15:00 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the kernel unit test menu structure from a flat layout to a hierarchical tree structure based on code organization. The changes improve menu navigation by grouping related tests under logical categories (Kernel Core, Kernel Components/Drivers, etc.) and standardize menu text by using "Test" instead of "Unit Testcase" with proper capitalization for better readability.
Key changes:
- Restructured Kconfig menu hierarchy to create multi-level organization
- Standardized all menu and option text to use consistent "Test" nomenclature with title case
- Renamed configuration option from
UTEST_MEMPOOL_TCtoRT_UTEST_MEMPOOLfor consistency
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Kconfig.utestcases | Reorganized top-level menu structure into "Kernel Core" and "Kernel Components" hierarchies |
| src/utest/Kconfig | Updated menu title and standardized test option descriptions with title case |
| src/utest/smp/Kconfig | Standardized SMP test descriptions with title case |
| src/utest/SConscript | Updated config dependency from UTEST_MEMPOOL_TC to RT_UTEST_MEMPOOL |
| src/klibc/utest/Kconfig | Simplified menu text to "Kernel Libc Test" |
| examples/utest/configs/kernel/mem.cfg | Updated config reference to RT_UTEST_MEMPOOL |
| components/utilities/utest/utest/Kconfig | Changed menu title to "Utest Framework" |
| components/net/utest/Kconfig | Standardized network test menu and option titles |
| components/libc/cplusplus/utest/Kconfig | Updated CPP11 menu and option titles |
| components/drivers/*/utest/Kconfig | Standardized driver test menu titles across serial, ipc, core, audio, and smp_call |
| components/dfs/utest/Kconfig | Updated filesystem test menu and option titles |
|
|
||
| config RT_SERIAL_TC_TXBUF_SIZE | ||
| int "the tx buffer size for serial test" | ||
| int "Tx Buffer Size for Serial Test" |
There was a problem hiding this comment.
Inconsistent capitalization: 'Tx' should be 'TX' to match 'RX' on line 20. / 大小写不一致:'Tx' 应改为 'TX' 以匹配第 20 行的 'RX'。
| int "Tx Buffer Size for Serial Test" | |
| int "TX Buffer Size for Serial Test" |
There was a problem hiding this comment.
Thanks,I already fixed.
Use "Test" instead of "Unit Testcases" to make string shorter. Use uppercase to make it look more eye-catching. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Which is missed in PR RT-Thread#10808 "utest: unify configname", add it. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
01c2344 to
a4c4aa8
Compare
|
@Rbb666 我已经修改了 Copliot 的检查结果。但我有个问题,是不是我们没有权限请求 Copilot review code 以及修改后 re-request review from Copilot? |
我使用的是 Copilot Pro 版本,免费试用30天的,开通就有这个功能了😂 |
最初的项目展示完全是平面的,现在它被组织成一个基于代码布局的树状层次结构。
mm 和 tmpfs 测试仍然保留,因为我们还没有处理(移动)这两个组件的源代码位置。
此外这个 pr 还改进菜单中显示的字符串,使用“Test” 代替“ Unit Testcases”以缩短字符串。使用大写字母使其看起来更醒目。
为方便 review,本 PR 分为三个 commit,merge时请不要压缩。最后一个 commit 是解决了PR #10808 “utest: unify configname” 中遗漏了的一个改动。
修改前的 menu 效果:
修改后的 menu 效果:
第一级:

注:mm 和 tempfs 两个维持原样,因为这两块还没有处理完, 如果按照现在的设计,以后也会合并入 core 或者 components
第二级 Kernel Core

第二级 Kernel Components
