add ra6e1-fpb by super-gith · Pull Request #10762 · RT-Thread/rt-thread

super-gith · 2025-09-30T04:47:06Z

拉取/合并请求描述：(PR description)

[
为什么提交这份PR (why to submit this PR)
Add bsp ra6e1-fpb.

请提供验证的bsp和config (provide the config and bsp)
bsp/renesas/ra6e1-fpb

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
[*] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
[* ] 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

modify ra6e1

github-actions · 2025-09-30T04:47:13Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：master
设置PR number为 \ Set the PR number to：10762

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

CLAassistant · 2025-09-30T04:47:15Z

All committers have signed the CLA.

github-actions · 2025-09-30T04:51:56Z

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)

bsp/renesas/ra6e1-fpb/.api_xml
bsp/renesas/ra6e1-fpb/.config
bsp/renesas/ra6e1-fpb/.gitignore
bsp/renesas/ra6e1-fpb/.ignore_format.yml
bsp/renesas/ra6e1-fpb/.secure_azone
bsp/renesas/ra6e1-fpb/.secure_xml
bsp/renesas/ra6e1-fpb/.settings/standalone.prefs
bsp/renesas/ra6e1-fpb/EventRecorderStub.scvd
bsp/renesas/ra6e1-fpb/Kconfig
bsp/renesas/ra6e1-fpb/README.md
bsp/renesas/ra6e1-fpb/SConscript
bsp/renesas/ra6e1-fpb/SConstruct
bsp/renesas/ra6e1-fpb/board/Kconfig
bsp/renesas/ra6e1-fpb/board/SConscript
bsp/renesas/ra6e1-fpb/board/board.h
bsp/renesas/ra6e1-fpb/board/ports/SConscript
bsp/renesas/ra6e1-fpb/board/ports/gpio_cfg.h
bsp/renesas/ra6e1-fpb/configuration.xml
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930112238070.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930112518592.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930112622622.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930112711356.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930113003433.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930114454018.png
bsp/renesas/ra6e1-fpb/docs/picture/image-20250930115014947.png
bsp/renesas/ra6e1-fpb/memory_regions.scat
bsp/renesas/ra6e1-fpb/project.uvoptx
bsp/renesas/ra6e1-fpb/project.uvprojx
bsp/renesas/ra6e1-fpb/ra/SConscript

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-11-30 14:02 CST)

⌛ Rbb666 Pending Review
⌛ kurisaW Pending Review
⌛ supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copilot

Pull Request Overview

This PR adds support for the RA6E1-FPB development board by including a new Board Support Package (BSP). The PR adds essential CMSIS 6 core header files to support ARM Cortex-M microcontrollers and provides the foundational infrastructure for the RA6E1-FPB board.

Key changes include:

Addition of CMSIS 6 core header files for ARM Cortex-M microcontrollers
Support files for multiple Cortex-M variants (M0, M0+, M1, SC000)
Architecture-specific implementations for ARMv7-M, ARMv8-M, and ARMv8.1-M features

Reviewed Changes

Copilot reviewed 46 out of 166 changed files in this pull request and generated 2 comments.

File	Description
bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/*.h	CMSIS 6 core header files providing ARM Cortex-M microcontroller support
cmsis_version.h	CMSIS version definitions for core components
core_cm*.h	Cortex-M core peripheral access layer headers for different variants
m-profile/*.h	ARM M-profile specific implementations for cache, MPU, PMU, and PAC features

Copilot · 2025-09-30T04:59:26Z

bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/m-profile/armv8m_mpu.h

+/* \brief Specifies MAIR_ATTR number */
+#define MAIR_ATTR(x)       ((x > 7 || x < 0) ? 0 : x)


[nitpick] [naming] 函数名 MAIR_ATTR 不够清晰。建议使用更具描述性的名称如 MAIR_ATTR_INDEX 或 MAIR_ATTR_VALIDATE。 / [naming] Function name MAIR_ATTR is unclear. Consider using a more descriptive name like MAIR_ATTR_INDEX or MAIR_ATTR_VALIDATE."

Suggested change

/* \brief Specifies MAIR_ATTR number */

#define MAIR_ATTR(x) ((x > 7 || x < 0) ? 0 : x)

/* \brief Specifies MAIR attribute index */

#define MAIR_ATTR_INDEX(x) ((x > 7 || x < 0) ? 0 : x)

这块是原厂生成文件，可以不用修改

好的，谢谢。我也觉得不用改。AI建议改的。

bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/m-profile/armv8m_mpu.h

…ile/armv8m_mpu.h 二进制数据转16进制 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Rbb666 · 2025-09-30T07:38:26Z

请在评论区附上正常运行的截图
需要在 .github/ALL_BSP_COMPILE.json 文件中 nxp_renesas 中添加此 BSP 的路径，这样 ci 就可以进行编译看护

super-gith · 2025-09-30T07:40:17Z

super-gith · 2025-09-30T07:42:02Z

Rbb666 · 2025-09-30T07:40:10Z

bsp/renesas/re6e1-fpb/README.md

+
+开发板正面外观如下图：
+
+![image-20250930115014947](G:\testRTT\rt-thread\bsp\renesas\re6e1-fpb\docs\picture\image-20250930115014947.png)


README.md 中的图片链接填写不正确

Rbb666 · 2025-09-30T07:40:46Z

bsp/renesas/re6e1-fpb/README.md

+| IIC                | 支持               | 软件           |
+| WDT                | 支持               |                |
+| RTC                | 支持               |                |
+| ADC                | 支持               |                |


请确认这些外设是否有都验证过，没有通过验证的先不要添加

Rbb666 · 2025-09-30T07:41:58Z

bsp/renesas/re6e1-fpb/src/hal_entry.c.orig

中间文件请删除，不要提交

Rbb666 · 2025-09-30T07:42:07Z

bsp/renesas/re6e1-fpb/template.uvguix.Administrator

Rbb666 · 2025-09-30T07:43:11Z

bsp/renesas/re6e1-fpb/project.uvguix.Administrator

这个应该也是中间文件，建议添加到 .gitignore 中

Rbb666 · 2025-09-30T07:43:20Z

bsp/renesas/re6e1-fpb/JLinkLog.txt

Rbb666 · 2025-09-30T07:43:29Z

bsp/renesas/re6e1-fpb/JLinkSettings.ini

Rbb666 · 2025-09-30T07:43:40Z

bsp/renesas/re6e1-fpb/buildinfo.gpdsc

Rbb666 · 2025-09-30T07:47:08Z

PR 标题建议作者描述清晰，此 PR 具体做了什么事情

Rbb666 · 2025-11-24T02:33:49Z

bsp/renesas/ra6e1-fpb/README.md

+
+开发板正面外观如下图：
+
+![image-20250930115014947](G:\testRTT\rt-thread\bsp\renesas\ra6e1-fpb\docs\picture\image-20250930115014947.png)


图片的链接不对，要换成相对docs/picture的路径才行

Rbb666 · 2025-11-24T02:35:12Z

bsp/renesas/re6e1-fpb/src/hal_entry.c.orig

多余的文件请删除提交

Rbb666 · 2025-11-24T02:36:12Z

bsp/renesas/re6e1-fpb/template.uvguix.Administrator

这个也需要删除

Copilot

Pull request overview

Copilot reviewed 46 out of 315 changed files in this pull request and generated 2 comments.

Copilot · 2025-11-24T02:37:34Z

bsp/renesas/ra6e1-fpb/board/ports/SConscript

+
+from building import *


PR标题缺少正确的前缀格式。根据RT-Thread代码规范，PR标题应遵循格式：[模块][子系统] 描述（小写）。建议修改为：[renesas][ra6e1-fpb] add bsp ra6e1-fpb

PR title is missing the proper prefix format. According to RT-Thread coding guidelines, the PR title should follow the format: [module][subsystem] Description (lowercase). Suggest changing to: [renesas][ra6e1-fpb] add bsp ra6e1-fpb

根据此处提示要求修改PR名称

Copilot · 2025-11-24T02:37:34Z

bsp/renesas/ra6e1-fpb/board/ports/SConscript

+
+from building import *


PR描述不够详细。根据RT-Thread PR审查清单，PR描述应包含：What（做了什么修改）、Why（为什么需要）、How（修改了哪些文件）。当前描述仅说明了添加了BSP，但缺少修改文件的列表和详细说明。建议添加：1) 添加的主要文件列表，2) CMSIS 6版本信息，3) 支持的编译器和工具链。

PR description is insufficient. According to RT-Thread PR review checklist, the description should include: What (what changes), Why (why needed), How (which files modified). The current description only mentions adding BSP but lacks a file list and detailed explanation. Suggest adding: 1) List of main files added, 2) CMSIS 6 version information, 3) Supported compilers and toolchains.

kurisaW · 2025-11-30T10:33:57Z

提交了两个重复的bsp，下面那个要删掉：

super-gith added 5 commits September 30, 2025 10:38

add ra6e1-fpb

ba9b4bd

Update README.md

888b99f

modify ra6e1

add ra6e1-fpb

29d2ba7

add ra6e1-fpb

1374c71

add ra6e1-fpb

e4b5fb6

super-gith requested review from Rbb666 and kurisaW as code owners September 30, 2025 04:47

github-actions bot added BSP BSP: Renesas BSP related with Renesas labels Sep 30, 2025

Rbb666 requested a review from Copilot September 30, 2025 04:58

Copilot AI reviewed Sep 30, 2025

View reviewed changes

Update bsp/renesas/re6e1-fpb/ra/arm/CMSIS_6/CMSIS/Core/Include/m-prof…

650f815

…ile/armv8m_mpu.h 二进制数据转16进制 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Rbb666 requested changes Sep 30, 2025

View reviewed changes

modify ALL_BSP_COMPILE

21d1434

super-gith requested a review from Rbb666 October 23, 2025 07:27

super-gith added 5 commits October 23, 2025 15:59

修改文档，重新编译工程，产生中间件。

0425c47

更新RA6E1工程，去掉中间件，更新readme

5f38970

Merge branch 'RT-Thread:master' into master

895f809

Merge branch 'master' of https://github.com/super-gith/rt-thread

bfead04

修改readme,去掉中间件，重新编译工程

a1b9cd6

super-gith requested a review from supperthomas as a code owner October 23, 2025 08:54

github-actions bot added the action github action yml imporve label Oct 23, 2025

Merge branch 'RT-Thread:master' into master

3e0d99c

Rbb666 added this to 单元测试（UTEST）Framework Nov 7, 2025

github-project-automation bot moved this to Todo in 单元测试（UTEST）Framework Nov 7, 2025

Rbb666 removed this from 单元测试（UTEST）Framework Nov 7, 2025

Rbb666 closed this Nov 24, 2025

Rbb666 reopened this Nov 24, 2025

Rbb666 requested changes Nov 24, 2025

View reviewed changes

Rbb666 requested a review from Copilot November 24, 2025 02:37

Copilot AI reviewed Nov 24, 2025

View reviewed changes

Merge branch 'RT-Thread:master' into master

29b1e28

		/* \brief Specifies MAIR_ATTR number */
		#define MAIR_ATTR(x) ((x > 7 \|\| x < 0) ? 0 : x)


		开发板正面外观如下图：

		![image-20250930115014947](G:\testRTT\rt-thread\bsp\renesas\re6e1-fpb\docs\picture\image-20250930115014947.png)


		开发板正面外观如下图：

		![image-20250930115014947](G:\testRTT\rt-thread\bsp\renesas\ra6e1-fpb\docs\picture\image-20250930115014947.png)

Conversation

super-gith commented Sep 30, 2025

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Sep 30, 2025

🛠 操作步骤 | Steps

Uh oh!

CLAassistant commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2025-11-30 14:02 CST)

📝 Review Instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rbb666 commented Sep 30, 2025

Uh oh!

super-gith commented Sep 30, 2025

Uh oh!

super-gith commented Sep 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rbb666 commented Sep 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

kurisaW commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

CLAassistant commented Sep 30, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading