componnets: drivers: adc: remove build warnings and cppcheck error#10373
Merged
Rbb666 merged 2 commits intoRT-Thread:masterfrom Jun 10, 2025
Merged
componnets: drivers: adc: remove build warnings and cppcheck error#10373Rbb666 merged 2 commits intoRT-Thread:masterfrom
Rbb666 merged 2 commits intoRT-Thread:masterfrom
Conversation
gcc build warnings: cast from pointer to integer of different size [-Wpointer-to-int-cast] For rt_adc_ops.enabled, the type of second param is rt_int8_t, original _adc_control also called with wrong type casting. Convert first to rt_base_t, then cast to rt_int8_t to remove the build warnings. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
[cpp_check.py 80 INFO] components/drivers/misc/adc.c:76:12:
error: Uninitialized variable: result [legacyUninitvar]
return result;
^
Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Rbb666
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 包含了两个 commit, 建议 merge 时不要压缩,保持 2 个 commit:
components/drivers/misc/adc.c中原因是在
components/drivers/misc/adc.c中存在如下代码:对于
rt_adc_ops.enabled,第二个参数的类型为rt_int8_t,这里将args强转为错误的类型。解决方法,先将其转换为
rt_base_t(保持宽度和指针一致,不加这个依然会告警),然后再强制转换为rt_int8_t,以消除构建警告。所以继续修改。
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up