[component/lwp]add annotation for lwp elf.#10230
Merged
BernardXiong merged 2 commits intoRT-Thread:masterfrom May 8, 2025
Merged
[component/lwp]add annotation for lwp elf.#10230BernardXiong merged 2 commits intoRT-Thread:masterfrom
BernardXiong merged 2 commits intoRT-Thread:masterfrom
Conversation
Member
|
感谢提交,不过lwp部分后续会进行一定重构,后续一些注释等方面的,等重构结束后再来推进吧。 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive annotations and documentation to the ELF loading functions within the LWP component, along with a minor copyright update.
- Updated copyright year
- Added detailed doc comments for functions and structure members
- Refactored inline comments to improve code clarity
components/lwp/lwp_elf.c
Outdated
Comment on lines
654
to
655
| /* When both the segment's virtual address and the load base are 0, it indicates that the segment should be loaded | ||
| at any available address rather than a fixed one. particularly useful for PIC or shared libraries.*/ |
There was a problem hiding this comment.
[nitpick] Consider revising the comment for improved clarity and proper sentence flow, e.g., 'When both the segment's virtual address and the load base are 0, the segment is loaded at any available address rather than a fixed one. This is particularly useful for PIC or shared libraries.'
Suggested change
| /* When both the segment's virtual address and the load base are 0, it indicates that the segment should be loaded | |
| at any available address rather than a fixed one. particularly useful for PIC or shared libraries.*/ | |
| /* When both the segment's virtual address and the load base are 0, the segment is loaded at any available | |
| address rather than a fixed one. This behavior is particularly useful for Position-Independent Code (PIC) | |
| or shared libraries. */ |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
supperthomas
approved these changes
Apr 30, 2025
BernardXiong
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
add annotation for lwp elf.
你的解决方案是什么 (what is your solution)
add annotation for lwp elf.
请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up