[tools] 添加scons --target别名scons --ide,减少用户对target的误解#10127
Closed
ComerLater wants to merge 1 commit intoRT-Thread:masterfrom
Closed
[tools] 添加scons --target别名scons --ide,减少用户对target的误解#10127ComerLater wants to merge 1 commit intoRT-Thread:masterfrom
ComerLater wants to merge 1 commit intoRT-Thread:masterfrom
Conversation
添加scons --target别名scons --ide,减少用户对target的误解
Member
|
cmake不属于ide |
Member
so, 怎么办?似乎target这个名称也还好? |
Member
|
改成--project-type吧,和上面的project-name一脉相承,用--而不是- |
Member
|
PR的意图我完全支持,改个命令名字就行 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the clarity of the scons build options by adding the "--ide" alias to the existing "--target" option, helping users better understand that the flag is meant for generating IDE projects.
- Added the "--ide" alias to the target flag
- Updated the help message to reflect the intended use for IDE projects
Comments suppressed due to low confidence (1)
tools/options.py:73
- [nitpick] Consider aligning the destination name with the new alias. For clarity, you might update 'dest' from 'target' to 'ide' if the flag is exclusively used for IDE project configuration, unless maintaining backward compatibility is a priority.
AddOption('--target', '--ide',
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
scons --target 的 target 意思给人很迷惑,一般用户都会理解为最终生成的target,而不是生成其他ide工程
你的解决方案是什么 (what is your solution)
添加 scons --ide 作为 --target 的别名,同时还保留原来的--target,ide这个名字意义大家一看就明白。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up