[fix][feature]Default to the previous fully packaged logic, add a 'di…#10064
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Mar 10, 2025
Merged
[fix][feature]Default to the previous fully packaged logic, add a 'di…#10064Rbb666 merged 1 commit intoRT-Thread:masterfrom
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
…st-strip' option for simplified packaging.
Contributor
Author
|
因为我今年面临考研的问题,尽管在时间上总体还比较充裕,但是为了保持时间分配的平衡,因此没有办法花太多时间,对于这个PR,我认为还存在一些可以改进的地方以及疑虑:
|
Member
感谢贡献 👍 由scons来生成compile_commands.json基本上应该是可行,好像有提及到可能生成不全,而再后续完善的基础上是基本可行的: |
supperthomas
requested changes
Mar 2, 2025
| action='store_true', | ||
| default=False, | ||
| help='create minimal distribution based on compile_commands.json.'+\ | ||
| 'So you should run `bear -- scons` to generate compile_commands.json first.') No newline at end of file |
Member
There was a problem hiding this comment.
compile_commands.json 可以通过命令scons --cdb生产,不过路径在build中。
@BernardXiong scons --cdb 要不改成默认的吧?就直接默认生成compile_commands.json
supperthomas
approved these changes
Mar 5, 2025
Rbb666
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st-strip' option for simplified packaging.
拉取/合并请求描述:(PR description)
[
正如在issue #10032 中所提到的,打包逻辑可能会出现问题,并且对于大部分用户而言,并不存在需要精简打包的需求。因此将默认的打包逻辑修改回原本的,另添加一个选项
--dist-strip用于精简打包。为什么提交这份PR (why to submit this PR)
修改bug。
你的解决方案是什么 (what is your solution)
保留原本的完全打包逻辑作为默认打包方案,添加一个选项--dist-strip用于精简打包。
但该精简打包依赖于compile_commands.json,需要执行
bear -- scons来生成这个依赖关系文件,这个在该新增选项的help当中也说明了。请提供验证的bsp和config (provide the config and bsp)
bsp/qemu-vexpress-a9]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up