bsp: cvitek: fix source command spelling in Kconfig#10035
Closed
KennethLiu61 wants to merge 1 commit intoRT-Thread:masterfrom
Closed
bsp: cvitek: fix source command spelling in Kconfig#10035KennethLiu61 wants to merge 1 commit intoRT-Thread:masterfrom
KennethLiu61 wants to merge 1 commit intoRT-Thread:masterfrom
Conversation
[Problem Description] The Kconfig file contained misspelled source commands: - "osource" instead of "source" for packages config inclusion - "rsource" instead of "source" for board config inclusion [Root Cause] Incorrect source command spelling breaks Kconfig processing: 1. "osource" is not a valid Kconfig command 2. "rsource" is not a valid Kconfig command 3. These typos prevent proper configuration inheritance [Solution] Correct the source command spellings: - Change "osource" to standard "source" for packages - Change "rsource" to standard "source" for board - Maintain original configuration hierarchy Signed-off-by: Liu Gui <kenneth.liu@sophgo.com>
Contributor
|
osourc 和 rsource 也是合法的命令吧,见 https://pypi.org/project/kconfiglib/#library-documentation 我觉得原来的写法没有问题呢。 |
Contributor
|
如果没有问题请 close 这个 PR |
Member
|
Please update env tool. old tool not support the latest code |
Contributor
Author
|
嗯嗯,明白。学习到了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[Problem Description]
The Kconfig file contained misspelled source commands:
[Root Cause]
Incorrect source command spelling breaks Kconfig processing:
[Solution]
Correct the source command spellings:
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up