Remove word boundaries to match error anywhere in the string #2194
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve https://github.com/ROCm/rocMLIR-internal/issues/2180
Technical Details
The change is simple but effective - it will now detect any line in the tuning log that contains "error" as a substring, making our CI error detection much more comprehensive.
Before:
/(?i)\berror\b/Used word boundaries (\b) that only matched "error" as a complete word
After:
/(?i)error/Removed word boundaries to match "error" anywhere in the string
Now the tuning error detection will catch:
✅ KeyError
✅ TypeError
✅ ValueError
✅ RuntimeError
✅ SomethingError
✅ error (standalone word still works)
✅ Any other text containing "error" (case-insensitive)
Test Plan
Test Result
Submission Checklist