Skip to content

Conversation

@dorde-antic
Copy link
Contributor

Motivation

Resolve https://github.com/ROCm/rocMLIR-internal/issues/2180

Technical Details

The change is simple but effective - it will now detect any line in the tuning log that contains "error" as a substring, making our CI error detection much more comprehensive.
Before: /(?i)\berror\b/
Used word boundaries (\b) that only matched "error" as a complete word
After: /(?i)error/
Removed word boundaries to match "error" anywhere in the string
Now the tuning error detection will catch:
✅ KeyError
✅ TypeError
✅ ValueError
✅ RuntimeError
✅ SomethingError
✅ error (standalone word still works)
✅ Any other text containing "error" (case-insensitive)

Test Plan

Test Result

Submission Checklist

@dorde-antic dorde-antic requested a review from causten as a code owner January 5, 2026 12:14
@dorde-antic dorde-antic requested review from mirza-halilcevic and umangyadav and removed request for causten and umangyadav January 5, 2026 12:14
@dorde-antic dorde-antic changed the title Removed word boundaries to match error anywhere in the string Remove word boundaries to match error anywhere in the string Jan 5, 2026
@dhernandez0
Copy link
Contributor

dhernandez0 commented Jan 7, 2026

are there any "error" message in the log that doesn't mean there's an error? For example, I think cmake can produce _ERROR_... and it doesn't mean an actual error.

@umangyadav
Copy link
Member

are there any "error" message in the log that doesn't mean there's an error? For example, I think cmake can produce _ERROR_... and it doesn't mean an actual error.

It is only seaching for "error" in tuning logs.

@dorde-antic dorde-antic merged commit 55f90b8 into develop Jan 8, 2026
14 of 15 checks passed
@dorde-antic dorde-antic deleted the improveerrordetection branch January 8, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants