Add custom multi_tensor_apply kernels (L2norm, Adam)#585
Open
matthiasdiener wants to merge 10 commits into
Open
Add custom multi_tensor_apply kernels (L2norm, Adam)#585matthiasdiener wants to merge 10 commits into
matthiasdiener wants to merge 10 commits into
Conversation
matthiasdiener
changed the title
matthiasdiener
changed the title
alextmagro
reviewed
May 16, 2026
alextmagro
requested changes
May 16, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matthiasdiener
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
alextmagro
reviewed
Jun 11, 2026
| nvte_multi_tensor_adam_cuda(chunk_size, noop_flag_cu.data(), tensor_lists_ptr.data(), num_lists, | ||
| num_tensors, lr, beta1, beta2, epsilon, step, mode, bias_correction, | ||
| weight_decay, at::cuda::getCurrentCUDAStream()); | ||
| if (num_lists == 4) { |
Contributor
There was a problem hiding this comment.
I think these changes, and some others, need to be hip guarded. I think this would break on NV since we exceed the kernel arg limit, right?
| /************************************************************************* | ||
| * This file was modified for portability to AMDGPU | ||
| * Copyright (c) 2026, Advanced Micro Devices, Inc. All rights reserved. | ||
| * Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. |
Contributor
There was a problem hiding this comment.
If this is new it should be only AMD copyright, and MIT license
ipanfilo
reviewed
Jun 17, 2026
| int ensure(int ntensors, int cs, int tc, | ||
| const std::vector<std::vector<at::Tensor>> &tensor_lists, | ||
| cudaStream_t stream) { | ||
| if (!shapes_valid(ntensors, cs, tensor_lists)) { |
Collaborator
There was a problem hiding this comment.
This code does not seem multithread safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/ROCm/frameworks-internal/issues/16529
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: