Replace prebuilt ARSCLib with git submodule#215
Open
Surendrajat wants to merge 1 commit intoREAndroid:masterfrom
Open
Replace prebuilt ARSCLib with git submodule#215Surendrajat wants to merge 1 commit intoREAndroid:masterfrom
Surendrajat wants to merge 1 commit intoREAndroid:masterfrom
Conversation
08c8ef5 to
ad6d72f
Compare
Owner
|
Thank you for this PR!
|
Author
@REAndroid it's a repo in repo so git clone --recurse-submodules https://github.com/REAndroid/APKEditor
cd APKEditor/module/ARSClib
git fetch
git checkout <whichever_commit_you_need>
cd ../..
git add -A && git commit -m "updated ARSClib"Also can you approve the workflow so I can confirm if it builds alright? |
Author
|
Looking at
|
Owner
I don't think they are going to maintain it, rather trying to kill it. Anyways we are deprecating dexlib2 with our lib and soon will be completely removed.
Let me merge this PR first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the need to build and manually update the ARSCLib library. Only update the ARSCLib submodule instead.
Submodule currently points to the REAndroid/ARSCLib@b942b9b commit of
mainbranch.Auto release on tags can also be added to the workflow if the maintainer likes the idea.