chore(eslint): add warning when using async preventDefault()

[Shane-Donlon]

What is it?

• Developer experience Improvement opportunity
  See also [🐞] onSubmit$ form handler not preventing default #7718

Description

Hey guys,
Feedback welcome - but thought I'd propose this as an idea.

While the knowledge exists in the documentation, the goal here is to prompt Developers that this is not a bug and to search the docs or to ask within Discord.

This does exclude sync$((e)=>{e.preventDefault()} functions, and I did add this as a warning over error just in case there was something else I wasn't considering, and wouldn't result in breaking any builds.

Checklist

• [ x] My code follows the developer guidelines of this project
• [x ] I performed a self-review of my own code
• [ x] I added new tests to cover the fix / functionality

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2bd41ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7723

npm i https://pkg.pr.new/@builder.io/qwik-city@7723

npm i https://pkg.pr.new/eslint-plugin-qwik@7723

npm i https://pkg.pr.new/create-qwik@7723

commit: 2bd41ef

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	2bd41ef

[maiieul]

Really good idea 🔥 Thanks a lot @Shane-Donlon!

[wmertens]

Looking good, but you also need to do stoppropagation

[gioboa]

What's missing here?

[Shane-Donlon]

Remaining to-do:

• improve warning message with feedback from Wout above.
• add stop propagation
• add tests for stop propagation

I was away last week and forgot to acknowledge the review, but should be able to get around to it this week.

What's missing here?

[gioboa]

Thanks @Shane-Donlon for your help.
is this PR still valid?

[wmertens]

[wmertens]

thansk @Shane-Donlon !