Implement Example in Combine#9
Open
Rion-Kaneshiro wants to merge 2 commits intoQuickBirdEng:combinefrom
Rion-Kaneshiro:combine
Open
Implement Example in Combine#9Rion-Kaneshiro wants to merge 2 commits intoQuickBirdEng:combinefrom Rion-Kaneshiro:combine
Rion-Kaneshiro wants to merge 2 commits intoQuickBirdEng:combinefrom
Rion-Kaneshiro:combine
Conversation
Collaborator
|
Thank you very much for the effort - I will have a deeper look in the coming days. It looks very promising so far, even though, I'm not sure whether the actions actually make much sense in that form - but I can currently also not think of a drastically better option 🙈 |
Author
|
Well they don't really make sense and I'll see what I can do to improve it ^^ |
Collaborator
|
Since the "Action" framework consists of more or less only one single file, we may be able to replicate it and thereby make it more similar to the Rx code. However I'm not quite sure whether that fits the "Combine style". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8
Reimplemented the Example using Apples Combine Framework and CombineCocoa instead of RxSwift and RxCocoa.
Caution:
This will remove the RxSwift implementation and should not be merged into master.
It should reside in a separate branch to provide a comparison between both Frameworks.