Skip to content

Comments

Swap button feature flag#397

Merged
n13 merged 22 commits intomainfrom
swap_button_feature_flag
Feb 19, 2026
Merged

Swap button feature flag#397
n13 merged 22 commits intomainfrom
swap_button_feature_flag

Conversation

@n13
Copy link
Collaborator

@n13 n13 commented Feb 19, 2026

  • Update to scanner screen
  • Remove swap button
  • Final version

await context.showFlash<void>(
duration: duration,
persistent: false,
persistent: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be persistent? this persistent is when the snackbar will not be closed unless it timeout the duration or user swipe it away. If user tap on screen it will not close it. Just want to make sure we wanted this behavior.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually that's not what persistent means

It's still going away after 2 seconds I tried it

Persistent is needed so it works when there's an action sheet

Copy link
Collaborator

@dewabisma dewabisma Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh okay, I thought persistent so it's not Dismissible by tap

Copy link
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add screenshots? Also there is one comment to confirm. Other than that all good!

Copy link
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship 🚢

@n13 n13 merged commit ae229c6 into main Feb 19, 2026
1 check passed
@dewabisma dewabisma deleted the swap_button_feature_flag branch February 20, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants