Merged
Conversation
dewabisma
reviewed
Feb 19, 2026
dewabisma
reviewed
Feb 19, 2026
dewabisma
reviewed
Feb 19, 2026
dewabisma
reviewed
Feb 19, 2026
dewabisma
requested changes
Feb 19, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Glass button looks good now with the new png!
Added few comments to answer or resolve
* swap screen updated - graphics icons - formatting numbers - quan at $1 * linter
when checksum is not yet loaded, the relevant share buttons etc should be disabled
…-apps into accounts_list_v3
Collaborator
Author
|
Fixed the issues All these very very good, thank you. I need to keep a more close eye on AI, these were just code bugs it introduced! |
dewabisma
reviewed
Feb 19, 2026
| final checkphrasePart = checksum != null && checksum.isNotEmpty && checksum != 'Loading...' && checksum != '-' | ||
| ? '\n\nCheckphrase:$checksum' | ||
| : ''; | ||
| String buildAccountShareText(String accountId, {required String checksum}) { |
dewabisma
reviewed
Feb 19, 2026
Collaborator
There was a problem hiding this comment.
So... it wasn't intentional 😏
dewabisma
approved these changes
Feb 19, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Looking great! Approved! 🚢 🚢 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accounts list
edit account
new account
a few smaller items from #388 resolved as well