GPU-friendly truncation implementations #349
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to get rid of the scalar-indexing oriented approach, and instead do more global operations.
Definitely still WIP, and on CPU there are definitely various optimizations that can be applied if needed.
I do wonder about the performance a bit, as I would actually expect that for a large number of sectors this might just be faster.
Some possible optimizations:
UniqueFusion, finding thenth value is simplypartialsortperm(values, n; by, rev), avoiding the need to allocate the full permutation vectorcumsum+findlastcan be replaced by a loop to avoid some intermediate allocations