transpose specialization for DiagonalTensorMap
#335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Jutho
previously approved these changes
Jan 1, 2026
Member
|
Tests seem to be failing though for fermionic DiagonalTensorMap instances. |
Member
|
Oh but it is just the newly added tests that are wrong. Permutation and transposition are not compatible in this case, though I agree that this might be very confusing. |
Member
Author
|
Will fix, I forgot about that subtle difference :) |
Jutho
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for an issue mentioned in #243, specifically for
transpose.The main point is to preserve the
DiagonalTensorMaptype whenever possible, rather than instantiating a dense tensor.