Error message improvements #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Jutho
reviewed
Nov 14, 2025
Jutho
reviewed
Nov 14, 2025
Jutho
reviewed
Nov 14, 2025
Member
Author
|
I think I addressed all comments, this is ready for review/merging |
Jutho
approved these changes
Nov 30, 2025
Jutho
referenced
this pull request
Dec 9, 2025
* initial basic design SectorVector * some additional functionality * relax `foreachblock` signature * replace `SectorDict` with `SectorVector` for eig/svdvals * export `svd_vals` * clean up SectorVector design * small fix * add finitedifferences support * update changelog * some simplifications and extensions * some further fixes * some more fixes * update dates --------- Co-authored-by: Jutho Haegeman <jutho.haegeman@ugent.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small changes and updates to the space checks.
I think after the "treetransformer" rewrite, because we create the transformer first and only then apply the indexmanipulation, we generated some very cryptic messages from deep inside the transformer code, which I now should have resolved a little earlier in the callchain.
While I was at it, I did the same for the tensor contractions.
Mostly I followed the same path of defining appropriate methods on the spaces themselves, but I'm happy to change things or move things around if that is appropriating a bit too much of these functions.