-
Notifications
You must be signed in to change notification settings - Fork 56
WIP: Documentation update/overhaul #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
I'd be happy to have the tutorial included here, the more people can find it and use it the better. I think you can pretty much just copy it as is for now. I can try to go through it again, make some edits and add some missing things in a later update. |
|
After the build completes, the updated documentation will be available here |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jutho, I feel like this is already a strict improvement, how do you feel about rebasing and just already merging this? I don't think we have to fix the entire documentation in one go, and I feel like incremental improvements might be the way to go here
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
Ok I've tried rebasing this so that this could be merged if CI works, but it seems like its acting a bit strangely. |
|
Ok, there seem to be some problems with the |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a small typo in one of the docstrings, and a formatting suggestion, otherwise good to go for me!
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
You will have to approve again. Feel free to merge at the same time if you are happy. |
* initial basic design SectorVector * some additional functionality * relax `foreachblock` signature * replace `SectorDict` with `SectorVector` for eig/svdvals * export `svd_vals` * clean up SectorVector design * small fix * add finitedifferences support * update changelog * some simplifications and extensions * some further fixes * some more fixes * update dates --------- Co-authored-by: Jutho Haegeman <jutho.haegeman@ugent.be>
Very much work in progress.
@leburgel , one of the things I would like to do, is to include your "Symmetric tensor deepdive" as an extra appendix in the documentation. Would you be ok with that? Then we would have two appendices. One for the theorists, one for the practicioners.