Skip to content

Conversation

@Jutho
Copy link
Member

@Jutho Jutho commented Sep 24, 2025

Very much work in progress.

@leburgel , one of the things I would like to do, is to include your "Symmetric tensor deepdive" as an extra appendix in the documentation. Would you be ok with that? Then we would have two appendices. One for the theorists, one for the practicioners.

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/spaces/productspace.jl 0.00% 2 Missing ⚠️
src/spaces/cartesianspace.jl 90.00% 1 Missing ⚠️
src/spaces/complexspace.jl 90.00% 1 Missing ⚠️
src/spaces/generalspace.jl 90.00% 1 Missing ⚠️
src/spaces/gradedspace.jl 94.11% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/spaces/homspace.jl 94.57% <ø> (ø)
src/spaces/vectorspaces.jl 79.06% <100.00%> (-0.48%) ⬇️
src/spaces/cartesianspace.jl 74.35% <90.00%> (-1.32%) ⬇️
src/spaces/complexspace.jl 85.71% <90.00%> (-1.79%) ⬇️
src/spaces/generalspace.jl 84.61% <90.00%> (ø)
src/spaces/gradedspace.jl 91.41% <94.11%> (-0.52%) ⬇️
src/spaces/productspace.jl 87.50% <0.00%> (-1.31%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel
Copy link
Member

I'd be happy to have the tutorial included here, the more people can find it and use it the better. I think you can pretty much just copy it as is for now. I can try to go through it again, make some edits and add some missing things in a later update.

@github-actions
Copy link
Contributor

After the build completes, the updated documentation will be available here

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jutho, I feel like this is already a strict improvement, how do you feel about rebasing and just already merging this? I don't think we have to fix the entire documentation in one go, and I feel like incremental improvements might be the way to go here

@Jutho
Copy link
Member Author

Jutho commented Nov 13, 2025

Ok I've tried rebasing this so that this could be merged if CI works, but it seems like its acting a bit strangely.

@Jutho
Copy link
Member Author

Jutho commented Nov 14, 2025

Ok, there seem to be some problems with the eig AD, but I don't think this can be caused by this PR. So if @lkdvos approves, this can be merged, and I'll continue with the rest of the docs in a following PR.

lkdvos
lkdvos previously approved these changes Nov 14, 2025
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo in one of the docstrings, and a formatting suggestion, otherwise good to go for me!

Co-authored-by: Lukas Devos <ldevos98@gmail.com>
@Jutho
Copy link
Member Author

Jutho commented Nov 14, 2025

You will have to approve again. Feel free to merge at the same time if you are happy.

@lkdvos lkdvos enabled auto-merge (squash) November 14, 2025 19:07
@lkdvos lkdvos disabled auto-merge November 14, 2025 22:28
@lkdvos lkdvos merged commit cc5e33b into main Nov 14, 2025
36 of 42 checks passed
@lkdvos lkdvos deleted the jh/docsupdate branch November 14, 2025 22:28
Jutho referenced this pull request Dec 9, 2025
* initial basic design SectorVector

* some additional functionality

* relax `foreachblock` signature

* replace `SectorDict` with `SectorVector` for eig/svdvals

* export `svd_vals`

* clean up SectorVector design

* small fix

* add finitedifferences support

* update changelog

* some simplifications and extensions

* some further fixes

* some more fixes

* update dates

---------

Co-authored-by: Jutho Haegeman <jutho.haegeman@ugent.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants